From: Matt Fleming <matt@console-pimps.org>
To: linux-efi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Matt Fleming <matt.fleming@intel.com>
Subject: [PATCH v3 0/6] Chainsaw efivars.c
Date: Wed, 17 Apr 2013 13:47:22 +0100 [thread overview]
Message-ID: <1366202848-5871-1-git-send-email-matt@console-pimps.org> (raw)
From: Matt Fleming <matt.fleming@intel.com>
drivers/firmware/efivars.c has grown pretty large and is ~2K lines.
Inside efivars.c there's currently,
o code for handling EFI variables at the firmware-level
o sysfs code for exposing EFI variables
o a new EFI variable filesystem
o a persistent storage backend
all intertwined and smushed together. This situation is only going to get worse
as new EFI support is added.
We need an interface that hides the EFI variable operations in use so code
isn't tempted to access them directly, e.g. efivarfs currently uses '__efivars'
which means it doesn't work for CONFIG_GOOGLE_SMI as that uses different
variable ops. With this interface in place, we can start moving independent
code out into separate files, allowing users to only turn on the functionality
that they want.
This patch series introduces the new efivar_entry API, and splits out the major
parts of efivars.c into new files. In particular, having the efivarfs code
under fs/ allows building an efivarfs.ko module, which means mount(8) can
automatically load it.
The remaining EFI code is repositioned under drivers/firmware/efi/.
The series is also available on the 'chainsaw' branch at,
git://git.kernel.org/pub/scm/linux/kernel/git/mfleming/efi.git
Changes in v3:
- Add Reviewed-by/Tested-by tags from Tom
- Add a parameter to efivar_init() to turn off the duplicate variable
detection. This is used in efivar_update_sysfs_entries()
because the workqueue function is only invoked if the firmware's
GetNextVariableName() is functioning properly.
Changes in v2:
- Add Reviewed-by/Acked-by tags from Mike
- Allow both EFI variable ops to be built as requested by Mike (PATCH 2)
- Fix deadlock and remove unnecessary logic changes in the pstore patch
reported by Seiji (PATCH 3)
Matt Fleming (5):
efi: move utf16 string functions to efi.h
efivars: Keep a private global pointer to efivars
efivars: efivar_entry API
efivars: Move pstore code into the new EFI directory
efivarfs: Move to fs/efivarfs
Tom Gundersen (1):
efi: split efisubsystem from efivars
MAINTAINERS | 13 +-
drivers/firmware/Kconfig | 36 +-
drivers/firmware/Makefile | 2 +-
drivers/firmware/efi/Kconfig | 39 +
drivers/firmware/efi/Makefile | 6 +
drivers/firmware/efi/efi-pstore.c | 244 +++++
drivers/firmware/efi/efi.c | 134 +++
drivers/firmware/efi/efivars.c | 617 +++++++++++
drivers/firmware/efi/vars.c | 1049 ++++++++++++++++++
drivers/firmware/efivars.c | 2171 -------------------------------------
drivers/firmware/google/gsmi.c | 30 +-
fs/Kconfig | 1 +
fs/Makefile | 1 +
fs/efivarfs/Kconfig | 12 +
fs/efivarfs/Makefile | 7 +
fs/efivarfs/file.c | 111 ++
fs/efivarfs/inode.c | 173 +++
fs/efivarfs/internal.h | 22 +
fs/efivarfs/super.c | 267 +++++
include/linux/efi.h | 134 ++-
20 files changed, 2835 insertions(+), 2234 deletions(-)
create mode 100644 drivers/firmware/efi/Kconfig
create mode 100644 drivers/firmware/efi/Makefile
create mode 100644 drivers/firmware/efi/efi-pstore.c
create mode 100644 drivers/firmware/efi/efi.c
create mode 100644 drivers/firmware/efi/efivars.c
create mode 100644 drivers/firmware/efi/vars.c
delete mode 100644 drivers/firmware/efivars.c
create mode 100644 fs/efivarfs/Kconfig
create mode 100644 fs/efivarfs/Makefile
create mode 100644 fs/efivarfs/file.c
create mode 100644 fs/efivarfs/inode.c
create mode 100644 fs/efivarfs/internal.h
create mode 100644 fs/efivarfs/super.c
--
1.7.10.4
next reply other threads:[~2013-04-17 12:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 12:47 Matt Fleming [this message]
2013-04-17 12:47 ` [PATCH 1/6] efi: move utf16 string functions to efi.h Matt Fleming
2013-04-17 12:47 ` [PATCH 2/6] efivars: Keep a private global pointer to efivars Matt Fleming
2013-04-17 12:47 ` [PATCH v3 3/6] efivars: efivar_entry API Matt Fleming
2013-04-17 12:47 ` [PATCH 4/6] efivars: Move pstore code into the new EFI directory Matt Fleming
2013-04-17 12:47 ` [PATCH 5/6] efivarfs: Move to fs/efivarfs Matt Fleming
2013-04-17 12:47 ` [PATCH 6/6] efi: split efisubsystem from efivars Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366202848-5871-1-git-send-email-matt@console-pimps.org \
--to=matt@console-pimps.org \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®