From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966610Ab3DQPcA (ORCPT ); Wed, 17 Apr 2013 11:32:00 -0400 Received: from mga11.intel.com ([192.55.52.93]:49053 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964900Ab3DQPb6 (ORCPT ); Wed, 17 Apr 2013 11:31:58 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,494,1363158000"; d="scan'208";a="323776623" Message-ID: <1366212711.2091.66.camel@rzhang1-mobl4> Subject: Re: [PATCH RESEND 10/11] thermal: update kernel-doc for create_trip_attrs From: Zhang Rui To: Eduardo Valentin Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 17 Apr 2013 23:31:51 +0800 In-Reply-To: <1365437258-31412-11-git-send-email-eduardo.valentin@ti.com> References: <1365437258-31412-1-git-send-email-eduardo.valentin@ti.com> <1365437258-31412-11-git-send-email-eduardo.valentin@ti.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2013-04-08 at 12:07 -0400, Eduardo Valentin wrote: > This patch updates the documentation for create_trip_attrs > and removes the warnings generated by scripts/kernel-doc -v. > > Signed-off-by: Eduardo Valentin this one looks okay to me. thanks, rui > --- > drivers/thermal/thermal_sys.c | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c > index f3a4e17..4cff199 100644 > --- a/drivers/thermal/thermal_sys.c > +++ b/drivers/thermal/thermal_sys.c > @@ -1460,9 +1460,14 @@ void thermal_notify_framework(struct thermal_zone_device *tz, int trip) > EXPORT_SYMBOL_GPL(thermal_notify_framework); > > /** > - * create_trip_attrs - create attributes for trip points > + * create_trip_attrs() - create attributes for trip points > * @tz: the thermal zone device > * @mask: Writeable trip point bitmap. > + * > + * helper function to instantiate sysfs entries for every trip > + * point and its properties of a struct thermal_zone_device. > + * > + * Return: 0 on success, the proper error value otherwise. > */ > static int create_trip_attrs(struct thermal_zone_device *tz, int mask) > {