From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: sameo@linux.intel.com
Cc: mchehab@redhat.com, andrew.smirnov@gmail.com, hverkuil@xs4all.nl,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: [PATCH 11/12] si476x: Fix some config dependencies and a compile warnings
Date: Thu, 18 Apr 2013 09:58:37 -0700 [thread overview]
Message-ID: <1366304318-29620-12-git-send-email-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <1366304318-29620-1-git-send-email-andrew.smirnov@gmail.com>
From: Hans Verkuil <hverkuil@xs4all.nl>
radio-si476x depends on SND and SND_SOC, the mfd driver should select
REGMAP_I2C.
Also fix a small compile warning in a debug message:
drivers/mfd/si476x-i2c.c: In function ‘si476x_core_drain_rds_fifo’:
drivers/mfd/si476x-i2c.c:391:4: warning: field width specifier ‘*’ expects argument of type ‘int’, but argument 4 has type ‘long unsigned int’ [-Wformat]
Acked-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
---
drivers/media/radio/Kconfig | 2 +-
drivers/mfd/Kconfig | 1 +
drivers/mfd/si476x-i2c.c | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
index 170460d..181a25f 100644
--- a/drivers/media/radio/Kconfig
+++ b/drivers/media/radio/Kconfig
@@ -20,7 +20,7 @@ source "drivers/media/radio/si470x/Kconfig"
config RADIO_SI476X
tristate "Silicon Laboratories Si476x I2C FM Radio"
- depends on I2C && VIDEO_V4L2
+ depends on I2C && VIDEO_V4L2 && SND && SND_SOC
select MFD_CORE
select MFD_SI476X_CORE
select SND_SOC_SI476X
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 3cd8f21..606e549 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -974,6 +974,7 @@ config MFD_SI476X_CORE
tristate "Support for Silicon Laboratories 4761/64/68 AM/FM radio."
depends on I2C
select MFD_CORE
+ select REGMAP_I2C
help
This is the core driver for the SI476x series of AM/FM
radio. This MFD driver connects the radio-si476x V4L2 module
diff --git a/drivers/mfd/si476x-i2c.c b/drivers/mfd/si476x-i2c.c
index 118c6b1..f5bc8e4 100644
--- a/drivers/mfd/si476x-i2c.c
+++ b/drivers/mfd/si476x-i2c.c
@@ -389,7 +389,7 @@ static void si476x_core_drain_rds_fifo(struct work_struct *work)
kfifo_in(&core->rds_fifo, report.rds,
sizeof(report.rds));
dev_dbg(&core->client->dev, "RDS data:\n %*ph\n",
- sizeof(report.rds), report.rds);
+ (int)sizeof(report.rds), report.rds);
}
dev_dbg(&core->client->dev, "Drrrrained!\n");
wake_up_interruptible(&core->rds_read_queue);
--
1.7.10.4
next prev parent reply other threads:[~2013-04-18 17:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 16:58 [PATCH v9 00/12] Driver for Si476x series of chips Andrey Smirnov
2013-04-18 16:58 ` [PATCH 01/12] mfd: Add commands abstraction layer for SI476X MFD Andrey Smirnov
2013-04-18 16:58 ` [PATCH 02/12] mfd: Add the main bulk of core driver for SI476x code Andrey Smirnov
2013-04-18 16:58 ` [PATCH 03/12] mfd: Add chip properties handling code for SI476X MFD Andrey Smirnov
2013-04-18 16:58 ` [PATCH 04/12] mfd: Add header files and Kbuild plumbing for SI476x MFD core Andrey Smirnov
2013-04-18 16:58 ` [PATCH 05/12] v4l2: Fix the type of V4L2_CID_TUNE_PREEMPHASIS in the documentation Andrey Smirnov
2013-04-18 16:58 ` [PATCH 06/12] v4l2: Add standard controls for FM receivers Andrey Smirnov
2013-04-18 16:58 ` [PATCH 07/12] v4l2: Add documentation for the FM RX controls Andrey Smirnov
2013-04-18 16:58 ` [PATCH 08/12] v4l2: Add private controls base for SI476X Andrey Smirnov
2013-04-18 16:58 ` [PATCH 09/12] v4l2: Add a V4L2 driver for SI476X MFD Andrey Smirnov
2013-04-18 22:26 ` Samuel Ortiz
2013-04-18 16:58 ` [PATCH 10/12] radio-si476x: vidioc_s* now uses a const parameter Andrey Smirnov
2013-04-18 16:58 ` Andrey Smirnov [this message]
2013-04-18 17:56 ` [PATCH 11/12] si476x: Fix some config dependencies and a compile warnings Samuel Ortiz
2013-04-18 16:58 ` [PATCH 12/12] radio-si476x: Fix incorrect pointer checking Andrey Smirnov
2013-04-18 17:48 ` Dan Carpenter
2013-04-18 17:28 ` [PATCH v9 00/12] Driver for Si476x series of chips Mauro Carvalho Chehab
2013-04-18 17:45 ` Samuel Ortiz
2013-04-18 17:57 ` Mauro Carvalho Chehab
2013-04-18 18:17 ` Samuel Ortiz
2013-04-18 18:23 ` Samuel Ortiz
2013-04-18 20:27 ` Mauro Carvalho Chehab
2013-04-19 21:31 ` Samuel Ortiz
2013-04-19 21:48 ` Andrey Smirnov
2013-04-21 5:53 ` Andrey Smirnov
2013-04-21 9:33 ` Mauro Carvalho Chehab
2013-04-22 2:01 ` Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366304318-29620-12-git-send-email-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®