mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Taras Kondratiuk <taras@ti.com>
To: <lgirdwood@gmail.com>, <broonie@kernel.org>, <rjw@sisk.pl>,
	<viresh.kumar@linaro.org>, <shawn.guo@linaro.org>
Cc: <cpufreq@vger.kernel.org>, <linux-pm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Taras Kondratiuk <taras@ti.com>
Subject: [RFC PATCH 0/2] cpufreq/regulator: Limit minimum voltage only
Date: Fri, 19 Apr 2013 14:55:52 +0300	[thread overview]
Message-ID: <1366372554-20866-1-git-send-email-taras@ti.com> (raw)

Using a "voltage tolerance" for doing DVFS is not a proper way.
It leads to a few issues:
- voltage is limited to a narrow range near OPP voltage,
  so other consumers of the same regulator can't set their own constraints
  if they don't overlap with this narrow range. No ganged rails :(
- usually OPP voltage is an absolute minimum voltage
  necessary for correct work (not taking into account AVS).
  Applying plus/minus tolerance can lead to an unstable device.
  For example omap-cpufreq has 4% tolerance configured,
  so for OMAP4430 MPU OPP50 we get 0.984V instead of 1.025V. 

This series adds a new API to regulator FW to limit only minimum voltage.
As example API is used for cpufreq-cpu0, but if it is accepted I'll fix
other drivers (omap-cpufreq, imx6q-cpufreq, etc).
Maybe regulator_set_voltage_tol() should be removed completely,
because it started to be used in a wrong way.
  
Patches are based on v3.9-rc7.
I've tested them on v3.8 based branch on OMAP4430 Blaze board.

Taras Kondratiuk (2):
  regulator: core: Add regulator_set_voltage_min()
  cpufreq: cpufreq-cpu0: Limit minimum voltage only

 drivers/cpufreq/cpufreq-cpu0.c     |   12 ++++--------
 include/linux/regulator/consumer.h |    6 ++++++
 2 files changed, 10 insertions(+), 8 deletions(-)

-- 
1.7.9.5


             reply	other threads:[~2013-04-19 12:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-19 11:55 Taras Kondratiuk [this message]
2013-04-19 11:55 ` [RFC PATCH 1/2] regulator: core: Add regulator_set_voltage_min() Taras Kondratiuk
2013-04-22 13:19   ` Mark Brown
2013-04-22 16:49     ` Taras Kondratiuk
2013-04-23  8:48       ` Mark Brown
2013-04-23 11:44         ` Taras Kondratiuk
2013-04-23 13:45           ` Mark Brown
2013-04-23 18:45             ` Taras Kondratiuk
2013-04-24  9:38               ` Mark Brown
2013-04-19 11:55 ` [RFC PATCH 2/2] cpufreq: cpufreq-cpu0: Limit minimum voltage only Taras Kondratiuk
2013-04-19 16:21 ` [RFC PATCH 0/2] cpufreq/regulator: " Nishanth Menon
2013-04-20  0:24   ` Kondratiuk, Taras
2013-04-22  6:11     ` Bedia, Vaibhav
2013-04-22 13:25       ` Mark Brown
2013-04-22 16:25       ` Taras Kondratiuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366372554-20866-1-git-send-email-taras@ti.com \
    --to=taras@ti.com \
    --cc=broonie@kernel.org \
    --cc=cpufreq@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=shawn.guo@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®