From: Ben Hutchings <ben@decadent.org.uk>
To: Luis Henriques <luis.henriques@canonical.com>
Cc: Jonghwan Choi <jhbird.choi@samsung.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
"'Zhang Rui'" <rui.zhang@intel.com>,
"'Richard Guy Briggs'" <rbriggs@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 3.8-stable] thermal: return an error on failure to register thermal
Date: Mon, 22 Apr 2013 01:50:46 +0100 [thread overview]
Message-ID: <1366591846.3408.126.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <20130403144702.GB3047@hercules>
[-- Attachment #1: Type: text/plain, Size: 2028 bytes --]
On Wed, 2013-04-03 at 15:47 +0100, Luis Henriques wrote:
> On Wed, Apr 03, 2013 at 09:38:55AM +0900, Jonghwan Choi wrote:
> > 3.8-stable review patch. If anyone has any objections, please let me know.
>
> I believe this is applicable to all the other stable kernels.
Queued up for 3.2, thanks.
Ben.
> Cheers,
> --
> Luis
>
> >
> > ------------------
> >
> > From: "Richard Guy Briggs <rbriggs@redhat.com>"
> >
> > commit da28d966f6aa942ae836d09729f76a1647932309 upstream.
> >
> > The return code from the registration of the thermal class is used to
> > unallocate resources, but this failure isn't passed back to the caller of
> > thermal_init. Return this failure back to the caller.
> >
> > This bug was introduced in changeset 4cb18728 which overwrote the return
> > code
> > when the variable was re-used to catch the return code of the registration
> > of
> > the genetlink thermal socket family.
> >
> > Signed-off-by: Richard Guy Briggs <rbriggs@redhat.com>
> > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> > ---
> > drivers/thermal/thermal_sys.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> > index 6472e7e..1a19a2f 100644
> > --- a/drivers/thermal/thermal_sys.c
> > +++ b/drivers/thermal/thermal_sys.c
> > @@ -1875,6 +1875,7 @@ static int __init thermal_init(void)
> > idr_destroy(&thermal_cdev_idr);
> > mutex_destroy(&thermal_idr_lock);
> > mutex_destroy(&thermal_list_lock);
> > + return result;
> > }
> > result = genetlink_init();
> > return result;
> > --
> > 1.7.9.5
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe stable" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Ben Hutchings
Klipstein's 4th Law of Prototyping and Production:
A fail-safe circuit will destroy others.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2013-04-22 0:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 0:38 Jonghwan Choi
2013-04-03 14:47 ` Luis Henriques
2013-04-22 0:50 ` Ben Hutchings [this message]
2013-04-03 16:26 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366591846.3408.126.camel@deadeye.wl.decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jhbird.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luis.henriques@canonical.com \
--cc=rbriggs@redhat.com \
--cc=rui.zhang@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®