From: liguang <lig.fnst@cn.fujitsu.com>
To: tglx@linutronix.de, peterz@infradead.org,
akpm@linux-foundation.org, shli@fusionio.com,
srivatsa.bhat@linux.vnet.ibm.com, suresh.b.siddha@intel.com,
fweisbec@gmail.com, sedat.dilek@gmail.com,
paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org
Cc: liguang <lig.fnst@cn.fujitsu.com>
Subject: [PATCH 1/2] smp: use '|=' for csd_lock
Date: Mon, 22 Apr 2013 13:47:22 +0800 [thread overview]
Message-ID: <1366609643-17628-1-git-send-email-lig.fnst@cn.fujitsu.com> (raw)
originally, 'data->flags = CSD_FLAG_LOCK',
and we use 'data->flags &= ~CSD_FLAG_LOCK'
for csd_unlock, they are not symmetrix operations
so use '|=' instead of '='.
though, now data->flags only hold CSD_FLAG_LOCK,
it's not so meaningful to use '|=' to set 1 bit,
and '&= ~' to clear 1 bit.
Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
---
kernel/smp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/smp.c b/kernel/smp.c
index 1818dc0..2d5deb4 100644
--- a/kernel/smp.c
+++ b/kernel/smp.c
@@ -109,7 +109,7 @@ static void csd_lock_wait(struct call_single_data *data)
static void csd_lock(struct call_single_data *data)
{
csd_lock_wait(data);
- data->flags = CSD_FLAG_LOCK;
+ data->flags |= CSD_FLAG_LOCK;
/*
* prevent CPU from reordering the above assignment
--
1.7.2.5
next reply other threads:[~2013-04-22 5:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 5:47 liguang [this message]
2013-04-22 5:47 ` [PATCH 2/2] smp: remove 'priv' of call_single_data liguang
2013-04-22 6:18 ` [PATCH 1/2] smp: use '|=' for csd_lock Sedat Dilek
2013-04-22 6:22 ` li guang
2013-04-22 6:30 ` Sedat Dilek
2013-04-22 6:49 ` Sedat Dilek
2013-04-23 22:40 ` Andrew Morton
2013-04-24 0:08 ` li guang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366609643-17628-1-git-send-email-lig.fnst@cn.fujitsu.com \
--to=lig.fnst@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=sedat.dilek@gmail.com \
--cc=shli@fusionio.com \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®