From: Huang Shijie <b32955@freescale.com>
To: <dwmw2@infradead.org>
Cc: <dedekind1@gmail.com>, <computersforpeace@gmail.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
Huang Shijie <b32955@freescale.com>
Subject: [PATCH v2 4/8] mtd: replace the hardcode with the onfi_get_feature()
Date: Mon, 22 Apr 2013 15:47:54 +0800 [thread overview]
Message-ID: <1366616878-29481-5-git-send-email-b32955@freescale.com> (raw)
In-Reply-To: <1366616878-29481-1-git-send-email-b32955@freescale.com>
The current code uses the hardcode to detect the 16-bit bus width.
Use the onfi_get_feature() to replace it.
Signed-off-by: Huang Shijie <b32955@freescale.com>
---
drivers/mtd/nand/nand_base.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 48ff097..ba87e43 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2957,9 +2957,9 @@ static int nand_flash_detect_onfi(struct mtd_info *mtd, struct nand_chip *chip,
mtd->oobsize = le16_to_cpu(p->spare_bytes_per_page);
chip->chipsize = le32_to_cpu(p->blocks_per_lun);
chip->chipsize *= (uint64_t)mtd->erasesize * p->lun_count;
- *busw = 0;
- if (le16_to_cpu(p->features) & 1)
- *busw = NAND_BUSWIDTH_16;
+
+ *busw = (onfi_feature(chip) & ONFI_FEATURE_16_BIT_BUS) ?
+ NAND_BUSWIDTH_16 : 0;
if (p->ecc_bits != 0xff) {
chip->ecc_strength = p->ecc_bits;
--
1.7.1
next prev parent reply other threads:[~2013-04-22 7:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 7:47 [PATCH v2 0/8] mtd: add datasheet's ECC information to nand_chip{} Huang Shijie
2013-04-22 7:47 ` [PATCH v2 1/8] mtd: add data structures for Extended Parameter Page Huang Shijie
2013-04-22 7:47 ` [PATCH v2 2/8] mtd: add a helper to get the supported features for ONFI nand Huang Shijie
2013-04-22 21:04 ` Brian Norris
2013-04-23 2:49 ` Huang Shijie
2013-04-22 7:47 ` [PATCH v2 3/8] mtd: get the ECC info from the Extended Parameter Page Huang Shijie
2013-04-22 21:22 ` Brian Norris
2013-04-23 2:43 ` Huang Shijie
2013-04-23 7:06 ` Brian Norris
2013-04-23 6:15 ` Huang Shijie
2013-04-22 7:47 ` Huang Shijie [this message]
2013-04-22 7:47 ` [PATCH v2 5/8] mtd: add a new field for ecc info in the nand_flash_dev{} Huang Shijie
2013-04-22 7:47 ` [PATCH v2 6/8] mtd: parse out the ECC info for the full-id nand chips Huang Shijie
2013-04-22 7:47 ` [PATCH v2 7/8] mtd: add the ecc info for some " Huang Shijie
2013-04-22 7:47 ` [PATCH v2 8/8] mtd: gpmi: set the BCH's geometry with the ecc info Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366616878-29481-5-git-send-email-b32955@freescale.com \
--to=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®