mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sourav Poddar <sourav.poddar@ti.com>
To: <gregkh@linuxfoundation.org>, <tony@atomide.com>,
	<rmk+kernel@arm.linux.org.uk>, <khilman@linaro.org>
Cc: <linux-serial@vger.kernel.org>, <linux-omap@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Sourav Poddar <sourav.poddar@ti.com>
Subject: [PATCHv2 2/5] driver: serial: omap: prevent runtime PM for "no_console_suspend"
Date: Mon, 22 Apr 2013 19:13:54 +0530	[thread overview]
Message-ID: <1366638237-6880-3-git-send-email-sourav.poddar@ti.com> (raw)
In-Reply-To: <1366638237-6880-1-git-send-email-sourav.poddar@ti.com>

The driver manages "no_console_suspend" by preventing runtime PM
during the suspend path, which forces the console UART to stay awake.

Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
 drivers/tty/serial/omap-serial.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 08332f3..640b14e 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -1582,7 +1582,7 @@ static int serial_omap_runtime_suspend(struct device *dev)
 	struct uart_omap_port *up = dev_get_drvdata(dev);
 	struct omap_uart_port_info *pdata = dev->platform_data;
 
-	if (!up)
+	if (!up || (!console_suspend_enabled && uart_console(&up->port)))
 		return -EINVAL;
 
 	if (!pdata)
@@ -1614,6 +1614,9 @@ static int serial_omap_runtime_resume(struct device *dev)
 
 	int loss_cnt = serial_omap_get_context_loss_count(up);
 
+	if (!console_suspend_enabled && uart_console(&up->port))
+		return -EINVAL;
+
 	if (loss_cnt < 0) {
 		dev_err(dev, "serial_omap_get_context_loss_count failed : %d\n",
 			loss_cnt);
-- 
1.7.1


  parent reply	other threads:[~2013-04-22 13:44 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-22 13:43 [PATCHv2 0/5] Serial Omap fixes and cleanups Sourav Poddar
2013-04-22 13:43 ` [PATCHv2 1/5] driver: tty: serial: Move "uart_console" def to core header file Sourav Poddar
2013-04-22 14:30   ` Felipe Balbi
2013-04-22 13:43 ` Sourav Poddar [this message]
2013-04-22 14:31   ` [PATCHv2 2/5] driver: serial: omap: prevent runtime PM for "no_console_suspend" Felipe Balbi
2013-04-23  4:52     ` Sourav Poddar
2013-04-22 14:48   ` Grygorii Strashko
2013-04-22 18:36     ` Kevin Hilman
2013-04-23  5:14       ` Sourav Poddar
2013-04-23  5:12     ` Sourav Poddar
2013-04-22 13:43 ` [PATCHv2 3/5] arm: omap2+: serial: remove no_console_suspend support Sourav Poddar
2013-04-22 14:32   ` Felipe Balbi
2013-04-22 13:43 ` [PATCHv2 4/5] arm: dts: am33xx: Remove "ti,no_idle_on_suspend" property Sourav Poddar
2013-04-22 14:35   ` Felipe Balbi
2013-04-23  4:53     ` Sourav Poddar
2013-04-22 13:43 ` [RFC/PATCHv2 5/5] arm: omap2+: omap_device: remove no_idle_on_suspend Sourav Poddar
2013-04-22 14:14   ` Grygorii Strashko
2013-04-22 18:41     ` Kevin Hilman
2013-04-23  5:19       ` Sourav Poddar
2013-04-23  9:19         ` Grygorii Strashko
2013-04-23  9:21           ` Sourav Poddar
2013-04-22 14:38   ` Felipe Balbi
2013-04-23  7:13     ` Peter Ujfalusi
2013-04-22 14:39   ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366638237-6880-3-git-send-email-sourav.poddar@ti.com \
    --to=sourav.poddar@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=khilman@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome