From: adam.lee@canonical.com
To: linux-kernel@vger.kernel.org
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Matthew Garrett <mjg@redhat.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Adam Lee <adam.lee@canonical.com>,
linux-media@vger.kernel.org (open list:USB VIDEO CLASS)
Subject: [PATCH] Revert "V4L/DVB: uvc: Enable USB autosuspend by default on uvcvideo"
Date: Wed, 24 Apr 2013 15:57:19 +0800 [thread overview]
Message-ID: <1366790239-838-1-git-send-email-adam.lee@canonical.com> (raw)
From: Adam Lee <adam.lee@canonical.com>
This reverts commit 3dae8b41dc5651f8eb22cf310e8b116480ba25b7.
1, I do have a Chicony webcam, implements autosuspend in a broken way,
make `poweroff` performs rebooting when its autosuspend enabled.
2, There are other webcams which don't support autosuspend too, like
https://patchwork.kernel.org/patch/2356141/
3, kernel removed USB_QUIRK_NO_AUTOSUSPEND in
a691efa9888e71232dfb4088fb8a8304ffc7b0f9, because autosuspend is
disabled by default.
So, we need to disable autosuspend in uvcvideo, maintaining a quirk list
only for uvcvideo is not a good idea.
Signed-off-by: Adam Lee <adam.lee@canonical.com>
---
drivers/media/usb/uvc/uvc_driver.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index 5dbefa6..8556f7c 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -1914,7 +1914,6 @@ static int uvc_probe(struct usb_interface *intf,
}
uvc_trace(UVC_TRACE_PROBE, "UVC device initialized.\n");
- usb_enable_autosuspend(udev);
return 0;
error:
--
1.7.10.4
next reply other threads:[~2013-04-24 7:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 7:57 adam.lee [this message]
2013-04-24 9:17 ` Laurent Pinchart
2013-04-25 6:33 ` Adam Lee
2013-06-13 9:56 ` Adam Lee
2013-09-24 11:34 ` Laurent Pinchart
2013-09-24 15:58 ` VDR User
[not found] ` <CAA7C2qi_1yYeSYbRBFhaLLwEmFf0k4G52jwvXVk0yLpNFFPCJA@mail.gmail.com>
2013-09-30 14:49 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366790239-838-1-git-send-email-adam.lee@canonical.com \
--to=adam.lee@canonical.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®