From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757735Ab3DYMnL (ORCPT ); Thu, 25 Apr 2013 08:43:11 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:21862 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756471Ab3DYMnJ (ORCPT ); Thu, 25 Apr 2013 08:43:09 -0400 X-Authority-Analysis: v=2.0 cv=cOZiQyiN c=1 sm=0 a=rXTBtCOcEpjy1lPqhTCpEQ==:17 a=mNMOxpOpBa8A:10 a=BTRBD928usAA:10 a=5SG0PmZfjMsA:10 a=IkcTkHD0fZMA:10 a=meVymXHHAAAA:8 a=YPD5nf4ZmOMA:10 a=pfhoThWEj4EtkNIyXV8A:9 a=QEXdDO2ut3YA:10 a=9J5VuaLb3qoA:10 a=rXTBtCOcEpjy1lPqhTCpEQ==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 74.67.115.198 Message-ID: <1366893787.10248.4.camel@gandalf.local.home> Subject: Re: [ANNOUNCE] 3.4.41-rt55-feat1 From: Steven Rostedt To: Mike Galbraith Cc: Sebastian Andrzej Siewior , Tim Sander , LKML , RT , Thomas Gleixner , Carsten Emde , John Kacur Date: Thu, 25 Apr 2013 08:43:07 -0400 In-Reply-To: <1366893374.6139.5.camel@marge.simpson.net> References: <1366760662.9609.176.camel@gandalf.local.home> <2156546.QlsX0XyPQz@dabox> <51792277.8000205@linutronix.de> <1366893374.6139.5.camel@marge.simpson.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2013-04-25 at 14:36 +0200, Mike Galbraith wrote: > On Thu, 2013-04-25 at 14:32 +0200, Sebastian Andrzej Siewior wrote: > > On 04/25/2013 01:14 PM, Tim Sander wrote: > > > Hi > > > > > > I just wanted to test this release but it fails to compile with the the > > > following error: > > > > > > kernel/hrtimer.c: In function '__hrtimer_start_range_ns': > > > kernel/hrtimer.c:1045:7: error: implicit declaration of function > > > 'hrtimer_rt_defer' > > > kernel/hrtimer.c: At top level: > > > kernel/hrtimer.c:1416:12: error: static declaration of 'hrtimer_rt_defer' > > > follows non-static declaration > > > kernel/hrtimer.c:1045:10: note: previous implicit declaration of > > > 'hrtimer_rt_defer' was here > > > > > > The kernelconfig is attached. > > > > You do not have CONFIG_HIGH_RES_TIMERS defined. Is this on purpose? > > git@marge:~/linux-2.6> ls -1 arch/arm/configs|wc -l > 122 > git@marge:~/linux-2.6> grep -IR CONFIG_HIGH_RES_TIMERS arch/arm/configs|wc -l > 31 > > Oh. Sniff, poor little things. > > hrtimer: fix hrtimer free zone build bug Perhaps the better solution is to select HIGH_RES_TIMERS when PREEMPT_RT_FULL is selected? -- Steve > > Signed-off-by: Mike Galbraith > > diff --git a/kernel/hrtimer.c b/kernel/hrtimer.c > index 2328c04..31d57a2 100644 > --- a/kernel/hrtimer.c > +++ b/kernel/hrtimer.c > @@ -1036,7 +1036,7 @@ int __hrtimer_start_range_ns(struct hrtimer *timer, ktime_t tim, > && hrtimer_enqueue_reprogram(timer, new_base)) { > > if (wakeup > -#ifdef CONFIG_PREEMPT_RT_BASE > +#if defined(CONFIG_PREEMPT_RT_BASE) && defined(CONFIG_HIGH_RES_TIMERS) > /* > * Move softirq based timers away from the rbtree in > * case it expired already. Otherwise we would have a >