mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Varun Sethi <Varun.Sethi@freescale.com>,
	Joerg Roedel <joro@8bytes.org>
Subject: [PATCH 13/21] iommu: tegra: print dma_addr_t using %lld
Date: Thu, 25 Apr 2013 19:28:56 +0200	[thread overview]
Message-ID: <1366910944-3033663-14-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1366910944-3033663-1-git-send-email-arnd@arndb.de>

The code was recently changed to work for builds with a 64 bit
dma_addr_t, but the printk unconditionally uses a format
string for an "long" variable, which is always wrong as
the dma_add_t is now either 'unsigned int' or 'unsigned long long'
depending on configuration.

The easiest solution is to cast the variable to u64 and print
it as a 64 bit value.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Varun Sethi <Varun.Sethi@freescale.com>
Cc: Joerg Roedel <joro@8bytes.org>
---
 drivers/iommu/tegra-gart.c | 3 ++-
 drivers/iommu/tegra-smmu.c | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/iommu/tegra-gart.c b/drivers/iommu/tegra-gart.c
index 4aec8be..ebbdd82 100644
--- a/drivers/iommu/tegra-gart.c
+++ b/drivers/iommu/tegra-gart.c
@@ -295,7 +295,8 @@ static phys_addr_t gart_iommu_iova_to_phys(struct iommu_domain *domain,
 
 	pa = (pte & GART_PAGE_MASK);
 	if (!pfn_valid(__phys_to_pfn(pa))) {
-		dev_err(gart->dev, "No entry for %08lx:%08x\n", iova, pa);
+		dev_err(gart->dev, "No entry for %08llx:%pa\n",
+				(u64)iova, &pa);
 		gart_dump_table(gart);
 		return -EINVAL;
 	}
diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
index bc9b599..ef2a120 100644
--- a/drivers/iommu/tegra-smmu.c
+++ b/drivers/iommu/tegra-smmu.c
@@ -772,7 +772,7 @@ static phys_addr_t smmu_iommu_iova_to_phys(struct iommu_domain *domain,
 	pfn = *pte & SMMU_PFN_MASK;
 	WARN_ON(!pfn_valid(pfn));
 	dev_dbg(as->smmu->dev,
-		"iova:%08lx pfn:%08lx asid:%d\n", iova, pfn, as->asid);
+		"iova:%08llx pfn:%08lx asid:%d\n", (u64)iova, pfn, as->asid);
 
 	spin_unlock_irqrestore(&as->lock, flags);
 	return PFN_PHYS(pfn);
-- 
1.8.1.2


  parent reply	other threads:[~2013-04-25 17:29 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-25 17:28 [PATCH 00/21] more arm build fixes Arnd Bergmann
2013-04-25 17:28 ` [PATCH 01/21] ARM: topology: export cpu_topology Arnd Bergmann
2013-04-26  8:53   ` Will Deacon
2013-04-26 15:07     ` Arnd Bergmann
2013-04-25 17:28 ` [PATCH 02/21] ARM: default machine descriptor for multiplatform Arnd Bergmann
2013-04-25 17:28 ` [PATCH 03/21] ARM: shmobile: don't call irqchip_init unconditionally Arnd Bergmann
2013-04-26  0:48   ` Simon Horman
2013-04-26  8:52     ` Bastian Hecht
2013-04-29 12:58       ` [PATCH 03/21] ARM: shmobile: don't call irqchip_init unconditionallyA Arnd Bergmann
2013-04-29 14:49     ` [PATCH 03/21] ARM: shmobile: don't call irqchip_init unconditionally Arnd Bergmann
2013-04-30  1:58       ` Simon Horman
2013-04-30  2:25         ` Simon Horman
2013-05-01 15:54   ` Rob Herring
2013-05-01 22:57     ` Simon Horman
2013-05-08 12:16       ` Arnd Bergmann
2013-05-08 13:22         ` Bastian Hecht
2013-05-08 13:34           ` Arnd Bergmann
2013-05-09  3:38           ` Simon Horman
2013-05-09  4:22             ` Simon Horman
2013-04-25 17:28 ` [PATCH 04/21] ARM: orion5x: include linux/cpu.h Arnd Bergmann
2013-04-25 17:34   ` Jason Cooper
2013-04-25 18:27     ` Jason Cooper
2013-04-25 17:28 ` [PATCH 05/21] atm: he: use mdelay instead of large udelay constants Arnd Bergmann
2013-04-26  8:21   ` David Laight
2013-04-26 13:12     ` chas williams - CONTRACTOR
2013-04-29 13:13       ` [PATCH v2 05/21] atm: he: use msleep " Arnd Bergmann
2013-04-29 17:27         ` David Miller
2013-04-25 17:28 ` [PATCH 06/21] ALSA: ali5451: use mdelay " Arnd Bergmann
2013-04-26  5:40   ` Takashi Iwai
2013-04-25 17:28 ` [PATCH 07/21] oss/dmabuf: use dma_map_single Arnd Bergmann
2013-04-26  5:41   ` Takashi Iwai
2013-04-25 17:28 ` [PATCH 08/21] drm/nouveau: use mdelay instead of large udelay constants Arnd Bergmann
2013-04-25 17:28 ` [PATCH 09/21] drm: export drm_vm_open_locked Arnd Bergmann
2013-04-25 17:28 ` [PATCH 10/21] [SCSI] nsp32: use mdelay instead of large udelay constants Arnd Bergmann
2013-04-26  0:42   ` Masanori Goto
2013-04-29 13:21     ` Arnd Bergmann
2013-04-29 21:41       ` Masanori Goto
2013-05-01 13:55       ` James Bottomley
2013-04-25 17:28 ` [PATCH 11/21] irqdomain: export irq_domain_add_simple Arnd Bergmann
2013-04-26  0:50   ` Simon Horman
2013-05-31 22:37     ` Grant Likely
2013-04-25 17:28 ` [PATCH 12/21] irqchip: s3c24xx: add missing __init annotations Arnd Bergmann
2013-04-26 10:39   ` Heiko Stübner
2013-04-25 17:28 ` Arnd Bergmann [this message]
2013-04-25 17:42   ` [PATCH 13/21] iommu: tegra: print dma_addr_t using %lld Sethi Varun-B16395
2013-04-25 17:28 ` [PATCH 14/21] cpufreq: pxa2xx: initialize variables Arnd Bergmann
2013-04-25 18:14   ` Rafael J. Wysocki
2013-04-25 21:09     ` Arnd Bergmann
2013-04-25 17:28 ` [PATCH 15/21] thermal: cooling: avoid uninitialied used gcc warning Arnd Bergmann
2013-04-25 20:07   ` edubezval
2013-04-25 21:09     ` Arnd Bergmann
2013-04-26  8:10   ` Zhang Rui
2013-04-25 17:28 ` [PATCH 16/21] OF: remove #ifdef from linux/of_platform.h Arnd Bergmann
2013-04-25 17:29 ` [PATCH 17/21] X.509: do not emit any informational output Arnd Bergmann
2013-04-25 17:29 ` [PATCH 18/21] USB: ehci-msm: USB_MSM_OTG needs USB_PHY Arnd Bergmann
2013-04-25 17:59   ` Greg Kroah-Hartman
2013-04-25 21:12     ` Arnd Bergmann
2013-04-25 17:29 ` [PATCH 19/21] USB: lpc32xx: ISP1301 " Arnd Bergmann
2013-04-25 19:50   ` Roland Stigge
2013-04-25 17:29 ` [PATCH 20/21] USB: OMAP: " Arnd Bergmann
2013-04-25 17:29 ` [PATCH 21/21] USB: OHCI: avoid conflicting platform drivers Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366910944-3033663-14-git-send-email-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=Varun.Sethi@freescale.com \
    --cc=joro@8bytes.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®