From: Julien Grall <julien.grall@linaro.org>
To: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org
Cc: konrad.wilk@oracle.com, Stefano.Stabellini@eu.citrix.com,
patches@linaro.org, Julien Grall <julien.grall@linaro.org>
Subject: [PATCH] xen: clear IRQ_NOAUTOEN and IRQ_NOREQUEST when a VIRQ is bound
Date: Mon, 29 Apr 2013 20:39:37 +0100 [thread overview]
Message-ID: <1367264377-7107-1-git-send-email-julien.grall@linaro.org> (raw)
Reset the IRQ_NOAUTOEN and IRQ_NOREQUEST flags that are enabled by
default on ARM. If IRQ_NOAUTOEN is set, __setup_irq doesn't call
irq_startup, that is responsible for calling irq_unmask at startup time.
As a result event channels remain masked.
The clear is already made in bind_evtchn_to_irq with commit a8636c0 but was
missing in bind_virq_to_irq.
Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
drivers/xen/events.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/xen/events.c b/drivers/xen/events.c
index d8cc812..b0ad226 100644
--- a/drivers/xen/events.c
+++ b/drivers/xen/events.c
@@ -994,6 +994,7 @@ int bind_virq_to_irq(unsigned int virq, unsigned int cpu)
WARN_ON(info == NULL || info->type != IRQT_VIRQ);
}
+ irq_clear_status_flags(irq, IRQ_NOREQUEST|IRQ_NOAUTOEN);
out:
mutex_unlock(&irq_mapping_update_lock);
--
1.7.10.4
next reply other threads:[~2013-04-29 19:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 19:39 Julien Grall [this message]
2013-04-30 15:02 ` Stefano Stabellini
2013-04-30 15:15 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367264377-7107-1-git-send-email-julien.grall@linaro.org \
--to=julien.grall@linaro.org \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®