From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
hpa@zytor.com, rostedt@goodmis.org, akpm@linux-foundation.org,
tglx@linutronix.de,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, Dave Hansen <dave@sr71.net>,
Stanislaw Gruszka <sgruszka@redhat.com>
Subject: [PATCH -tip 2/4] sched: Do not account bogus utime
Date: Tue, 30 Apr 2013 11:35:05 +0200 [thread overview]
Message-ID: <1367314507-9728-2-git-send-email-sgruszka@redhat.com> (raw)
In-Reply-To: <1367314507-9728-1-git-send-email-sgruszka@redhat.com>
Due to rounding in scale_stime(), for big numbers, scaled stime values
will grow in chunks. Since rtime grow in jiffies and we calculate utime
like below:
prev->stime = max(prev->stime, stime);
prev->utime = max(prev->utime, rtime - prev->stime);
we could erroneously account stime values as utime. To prevent that only
update prev->{u,s}time values when they are smaller than current rtime.
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
kernel/sched/cputime.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
index b3dd984..3f192bf 100644
--- a/kernel/sched/cputime.c
+++ b/kernel/sched/cputime.c
@@ -581,6 +581,14 @@ static void cputime_adjust(struct task_cputime *curr,
*/
rtime = nsecs_to_cputime(curr->sum_exec_runtime);
+ /*
+ * Update userspace visible utime/stime values only if actual execution
+ * time is bigger than already exported. Note that can happen, that we
+ * provided bigger values due to scaling inaccuracy on big numbers.
+ */
+ if (prev->stime + prev->utime >= rtime)
+ goto out;
+
if (!rtime) {
stime = 0;
} else if (!total) {
@@ -598,6 +606,7 @@ static void cputime_adjust(struct task_cputime *curr,
prev->stime = max(prev->stime, stime);
prev->utime = max(prev->utime, rtime - prev->stime);
+out:
*ut = prev->utime;
*st = prev->stime;
}
--
1.7.11.7
next prev parent reply other threads:[~2013-04-30 9:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 9:35 [PATCH -tip 1/4] sched: Avoid cputime scaling overflow Stanislaw Gruszka
2013-04-30 9:35 ` Stanislaw Gruszka [this message]
2013-05-01 10:04 ` [tip:sched/urgent] sched: Do not account bogus utime tip-bot for Stanislaw Gruszka
2013-04-30 9:35 ` [PATCH -tip 3/4] sched: Avoid prev->stime underflow Stanislaw Gruszka
2013-05-01 10:06 ` [tip:sched/urgent] " tip-bot for Stanislaw Gruszka
2013-04-30 9:35 ` [PATCH -tip 4/4] Revert "math64: New div64_u64_rem helper" Stanislaw Gruszka
2013-05-01 10:07 ` [tip:sched/urgent] " tip-bot for Stanislaw Gruszka
2013-04-30 11:11 ` [PATCH -tip 1/4] sched: Avoid cputime scaling overflow Ingo Molnar
2013-04-30 15:14 ` [PATCH -tip 1/4 v2] " Stanislaw Gruszka
2013-05-01 10:03 ` [tip:sched/urgent] " tip-bot for Stanislaw Gruszka
2013-05-02 13:10 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367314507-9728-2-git-send-email-sgruszka@redhat.com \
--to=sgruszka@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave@sr71.net \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®