From: Ambresh K <ambresh@ti.com>
To: Mike Turquette <mturquette@linaro.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
Tero Kristo <t-kristo@ti.com>, Rajendra <rnayak@ti.com>,
Ambresh K <ambresh@ti.com>, Nishanth Menon <nm@ti.com>
Subject: [Patch 3/3] clk: Avoid re-parenting orphan clk's having invalid parent index.
Date: Thu, 2 May 2013 11:55:29 +0530 [thread overview]
Message-ID: <1367475929-32166-4-git-send-email-ambresh@ti.com> (raw)
In-Reply-To: <1367475929-32166-1-git-send-email-ambresh@ti.com>
From: Ambresh K <ambresh@ti.com>
Add orhan clk nodes having invalid parent index to list and use
the list to skip re-parenting orphan clk having invalid parents.
Signed-off-by: Ambresh K <ambresh@ti.com>
---
drivers/clk/clk.c | 21 +++++++++++++++++++--
1 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index f4d2c73..54d2aa3 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -32,6 +32,7 @@ static int enable_refcnt;
static HLIST_HEAD(clk_root_list);
static HLIST_HEAD(clk_orphan_list);
+static HLIST_HEAD(clk_orphan_invalid_parent);
static LIST_HEAD(clk_notifier_list);
/*** locking ***/
@@ -1532,8 +1533,8 @@ EXPORT_SYMBOL_GPL(clk_set_parent);
*/
int __clk_init(struct device *dev, struct clk *clk)
{
- int i, ret = 0;
- struct clk *orphan;
+ int i, ret = 0, skip = 0;
+ struct clk *orphan, *has_invalid_parent;
struct hlist_node *tmp2;
if (!clk)
@@ -1639,11 +1640,27 @@ int __clk_init(struct device *dev, struct clk *clk)
if (!strcmp(clk->name, orphan->name))
continue;
+ /* Skip iteration if orphan has invalid parent */
+ hlist_for_each_entry(has_invalid_parent,
+ &clk_orphan_invalid_parent, child_node) {
+ if (!strcmp(orphan->name, has_invalid_parent->name)) {
+ skip = 1;
+ break;
+ }
+ }
+
+ if (skip) {
+ skip = 0;
+ continue;
+ }
+
if (orphan->ops->get_parent) {
i = orphan->ops->get_parent(orphan->hw);
if (i < 0) {
pr_err("%s: orphan clk(%s) invalid parent\n",
__func__, orphan->name);
+ hlist_add_head(&orphan->child_node,
+ &clk_orphan_invalid_parent);
continue;
}
if (!strcmp(clk->name, orphan->parent_names[i]))
--
1.7.4.1
next prev parent reply other threads:[~2013-05-02 6:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 6:25 [Patch 0/3] Fix to clk framework while handling orphan clks Ambresh K
2013-05-02 6:25 ` [Patch 1/3] clk: fix clk_mux_get_parent return's signed value Ambresh K
[not found] ` <20130529072118.6058.14433@quantum>
2013-06-04 6:27 ` Ambresh K
2013-06-04 6:35 ` Mike Turquette
2013-05-02 6:25 ` [Patch 2/3] clk: skip re-parenting orphan clk Ambresh K
2013-05-02 10:09 ` skannan
2013-05-02 6:25 ` Ambresh K [this message]
[not found] ` <20130529071809.6058.24017@quantum>
2013-06-04 7:16 ` [Patch 3/3] clk: Avoid re-parenting orphan clk's having invalid parent index Ambresh K
[not found] ` <20130611220744.8816.8856@quantum>
2013-06-13 7:06 ` Ambresh K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367475929-32166-4-git-send-email-ambresh@ti.com \
--to=ambresh@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=nm@ti.com \
--cc=rnayak@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome