From: kosaki.motohiro@gmail.com
To: linux-kernel@vger.kernel.org
Cc: Olivier Langlois <olivier@trillion01.com>,
Thomas Gleixner <tglx@linutronix.de>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: [PATCH 1/7] posix-cpu-timers: don't account cpu timer after stopped thread runtime accounting
Date: Fri, 3 May 2013 00:47:42 -0400 [thread overview]
Message-ID: <1367556468-4021-3-git-send-email-kosaki.motohiro@gmail.com> (raw)
In-Reply-To: <1367556468-4021-1-git-send-email-kosaki.motohiro@gmail.com>
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
When tsk->signal->cputimer->running is 1, signal->cputimer and
tsk->sum_sched_runtime increase at the same pace because update_curr()
increases both accounting.
However, there is one exception. When thread exiting, __exit_signal() turns
over task's sum_shced_runtime to sig->sum_sched_runtime, but it doesn't stop
signal->cputimer accounting.
This inconsistency makes POSIX timer wake up too early. This patch fixes it.
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Olivier Langlois <olivier@trillion01.com>
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
kernel/sched/stats.h | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/kernel/sched/stats.h b/kernel/sched/stats.h
index 2ef90a5..5a0cfc4 100644
--- a/kernel/sched/stats.h
+++ b/kernel/sched/stats.h
@@ -225,6 +225,13 @@ static inline void account_group_exec_runtime(struct task_struct *tsk,
if (!cputimer->running)
return;
+ /*
+ * After turning over se.sum_exec_runtime to sig->sum_sched_runtime
+ * in __exit_signal(), we must not account exec_runtime for consistency.
+ */
+ if (unlikely(!tsk->sighand))
+ return;
+
raw_spin_lock(&cputimer->lock);
cputimer->cputime.sum_exec_runtime += ns;
raw_spin_unlock(&cputimer->lock);
--
1.7.1
next prev parent reply other threads:[~2013-05-03 4:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 4:47 [PATCH v4 0/7] posix timers fixlet kosaki.motohiro
2013-05-03 4:47 ` kosaki.motohiro [this message]
2013-05-06 23:47 ` [PATCH 1/7] posix-cpu-timers: don't account cpu timer after stopped thread runtime accounting Frederic Weisbecker
2013-05-07 2:57 ` KOSAKI Motohiro
2013-05-07 15:24 ` Frederic Weisbecker
2013-05-26 21:38 ` KOSAKI Motohiro
2013-05-07 3:16 ` Olivier Langlois
2013-05-11 0:17 ` Frederic Weisbecker
2013-05-11 2:40 ` KOSAKI Motohiro
2013-05-03 4:47 ` [PATCH 2/7] posix-cpu-timers: fix acounting delta_exec twice kosaki.motohiro
2013-05-11 0:56 ` Frederic Weisbecker
2013-05-11 2:17 ` KOSAKI Motohiro
2013-05-03 4:47 ` [PATCH 3/7] posix-cpu-timers: fix wrong timer initialization kosaki.motohiro
2013-05-03 4:47 ` [PATCH 4/7] posix-cpu-timers: timer functions should use timer time instead of clock time kosaki.motohiro
2013-05-03 4:47 ` [PATCH 5/7] posix-cpu-timers: check_thread_timers() uses task_sched_runtime() kosaki.motohiro
2013-05-03 4:47 ` [PATCH 6/7] sched: task_sched_runtime introduce micro optimization kosaki.motohiro
2013-05-03 4:47 ` [PATCH 7/7] posix-cpu-timers: cleanup cpu_{clock,timer}_sample{,_group} kosaki.motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367556468-4021-3-git-send-email-kosaki.motohiro@gmail.com \
--to=kosaki.motohiro@gmail.com \
--cc=fweisbec@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=olivier@trillion01.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®