From: Jean Delvare <jdelvare@suse.de>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Takashi Iwai <tiwai@suse.de>
Subject: [PATCH] idr: Print a stack dump after ida_remove warning
Date: Sun, 05 May 2013 11:32:03 +0200 [thread overview]
Message-ID: <1367746323.4682.750.camel@chaos.site> (raw)
We print a dump stack after idr_remove warning. This is useful to find
the faulty piece of code. Let's do the same for ida_remove, as it
would be equally useful there.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Takashi Iwai <tiwai@suse.de>
---
lib/idr.c | 1 +
1 file changed, 1 insertion(+)
--- linux-3.10-rc0.orig/lib/idr.c 2013-05-05 10:17:03.086198024 +0200
+++ linux-3.10-rc0/lib/idr.c 2013-05-05 10:41:11.939134735 +0200
@@ -1066,6 +1066,7 @@ void ida_remove(struct ida *ida, int id)
err:
printk(KERN_WARNING
"ida_remove called for id=%d which is not allocated.\n", id);
+ dump_stack();
}
EXPORT_SYMBOL(ida_remove);
--
Jean Delvare
Suse L3
next reply other threads:[~2013-05-05 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-05 9:32 Jean Delvare [this message]
2013-05-07 23:34 ` Andrew Morton
2013-05-08 14:54 ` Takashi Iwai
2013-05-13 9:30 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367746323.4682.750.camel@chaos.site \
--to=jdelvare@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®