mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chao Xie <chao.xie@marvell.com>
To: <thierry.reding@avionic-design.de>,
	<linux-kernel@vger.kernel.org>, <xiechao.mail@gmail.com>,
	<eric.y.miao@gmail.com>
Cc: Chao Xie <chao.xie@marvell.com>
Subject: [PATCH V4 2/3] pwm: pxa: use module_platform_driver()
Date: Sun, 5 May 2013 21:30:00 -0400	[thread overview]
Message-ID: <1367803801-17111-3-git-send-email-chao.xie@marvell.com> (raw)
In-Reply-To: <1367803801-17111-1-git-send-email-chao.xie@marvell.com>

Old pwm-pxa.c will register driver by arch_initcall. Then other
drivers based on the PWM driver can successully call old
pwm_request because arch_initcall make sure the PWM driver will
be registered earlier.
Now, pwm_request is re-written and done by common layer code. It
will return -EPROBE_DEFER if the PWM device is not probed.
The driver based on PWM driver can make use of -EPROBE_DEFER
to delay its probing.
So arch_initcall can be replaced by module_platform_driver.

Signed-off-by: Chao Xie <chao.xie@marvell.com>
---
 drivers/pwm/pwm-pxa.c |   12 +-----------
 1 files changed, 1 insertions(+), 11 deletions(-)

diff --git a/drivers/pwm/pwm-pxa.c b/drivers/pwm/pwm-pxa.c
index dee6ab55..aa4bea7 100644
--- a/drivers/pwm/pwm-pxa.c
+++ b/drivers/pwm/pwm-pxa.c
@@ -187,16 +187,6 @@ static struct platform_driver pwm_driver = {
 	.id_table	= pwm_id_table,
 };
 
-static int __init pwm_init(void)
-{
-	return platform_driver_register(&pwm_driver);
-}
-arch_initcall(pwm_init);
-
-static void __exit pwm_exit(void)
-{
-	platform_driver_unregister(&pwm_driver);
-}
-module_exit(pwm_exit);
+module_platform_driver(pwm_driver);
 
 MODULE_LICENSE("GPL v2");
-- 
1.7.4.1


  parent reply	other threads:[~2013-05-06  1:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-06  1:29 [PATCH V4 0/3] pwm: pxa: bug fix and device tree support Chao Xie
2013-05-06  1:29 ` [PATCH V4 1/3] pwm: pxa: ARCH_MMP share same pwm driver with ARCH_PXA Chao Xie
2013-05-13  2:07   ` Eric Miao
2013-05-06  1:30 ` Chao Xie [this message]
2013-05-13  2:08   ` [PATCH V4 2/3] pwm: pxa: use module_platform_driver() Eric Miao
2013-05-06  1:30 ` [PATCH V4 3/3] pwm: pxa: add device tree support Chao Xie
2013-05-13  2:27   ` Eric Miao
2013-05-13  5:04     ` Chao Xie
2013-05-13  6:20       ` Eric Miao
2013-05-21  5:21         ` Chao Xie
2013-05-23 19:10           ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367803801-17111-3-git-send-email-chao.xie@marvell.com \
    --to=chao.xie@marvell.com \
    --cc=eric.y.miao@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thierry.reding@avionic-design.de \
    --cc=xiechao.mail@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®