From: Alex Shi <alex.shi@intel.com>
To: mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de,
akpm@linux-foundation.org, bp@alien8.de, pjt@google.com,
namhyung@kernel.org, efault@gmx.de, morten.rasmussen@arm.com
Cc: vincent.guittot@linaro.org, preeti@linux.vnet.ibm.com,
viresh.kumar@linaro.org, linux-kernel@vger.kernel.org,
alex.shi@intel.com, mgorman@suse.de, riel@redhat.com,
wangyun@linux.vnet.ibm.com
Subject: [PATCH v5 1/7] Revert "sched: Introduce temporary FAIR_GROUP_SCHED dependency for load-tracking"
Date: Mon, 6 May 2013 09:45:05 +0800 [thread overview]
Message-ID: <1367804711-30308-2-git-send-email-alex.shi@intel.com> (raw)
In-Reply-To: <1367804711-30308-1-git-send-email-alex.shi@intel.com>
Remove CONFIG_FAIR_GROUP_SCHED that covers the runnable info, then
we can use runnable load variables.
Signed-off-by: Alex Shi <alex.shi@intel.com>
---
include/linux/sched.h | 7 +------
kernel/sched/core.c | 7 +------
kernel/sched/fair.c | 13 ++-----------
kernel/sched/sched.h | 9 +--------
4 files changed, 5 insertions(+), 31 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index e692a02..9539597 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1161,12 +1161,7 @@ struct sched_entity {
struct cfs_rq *my_q;
#endif
-/*
- * Load-tracking only depends on SMP, FAIR_GROUP_SCHED dependency below may be
- * removed when useful for applications beyond shares distribution (e.g.
- * load-balance).
- */
-#if defined(CONFIG_SMP) && defined(CONFIG_FAIR_GROUP_SCHED)
+#ifdef CONFIG_SMP
/* Per-entity load-tracking */
struct sched_avg avg;
#endif
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 67d0465..c8db984 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -1563,12 +1563,7 @@ static void __sched_fork(struct task_struct *p)
p->se.vruntime = 0;
INIT_LIST_HEAD(&p->se.group_node);
-/*
- * Load-tracking only depends on SMP, FAIR_GROUP_SCHED dependency below may be
- * removed when useful for applications beyond shares distribution (e.g.
- * load-balance).
- */
-#if defined(CONFIG_SMP) && defined(CONFIG_FAIR_GROUP_SCHED)
+#ifdef CONFIG_SMP
p->se.avg.runnable_avg_period = 0;
p->se.avg.runnable_avg_sum = 0;
#endif
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 7a33e59..9c2f726 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1109,8 +1109,7 @@ static inline void update_cfs_shares(struct cfs_rq *cfs_rq)
}
#endif /* CONFIG_FAIR_GROUP_SCHED */
-/* Only depends on SMP, FAIR_GROUP_SCHED may be removed when useful in lb */
-#if defined(CONFIG_SMP) && defined(CONFIG_FAIR_GROUP_SCHED)
+#ifdef CONFIG_SMP
/*
* We choose a half-life close to 1 scheduling period.
* Note: The tables below are dependent on this value.
@@ -3394,12 +3393,6 @@ unlock:
}
/*
- * Load-tracking only depends on SMP, FAIR_GROUP_SCHED dependency below may be
- * removed when useful for applications beyond shares distribution (e.g.
- * load-balance).
- */
-#ifdef CONFIG_FAIR_GROUP_SCHED
-/*
* Called immediately before a task is migrated to a new cpu; task_cpu(p) and
* cfs_rq_of(p) references at time of call are still valid and identify the
* previous cpu. However, the caller only guarantees p->pi_lock is held; no
@@ -3422,7 +3415,6 @@ migrate_task_rq_fair(struct task_struct *p, int next_cpu)
atomic64_add(se->avg.load_avg_contrib, &cfs_rq->removed_load);
}
}
-#endif
#endif /* CONFIG_SMP */
static unsigned long
@@ -6114,9 +6106,8 @@ const struct sched_class fair_sched_class = {
#ifdef CONFIG_SMP
.select_task_rq = select_task_rq_fair,
-#ifdef CONFIG_FAIR_GROUP_SCHED
.migrate_task_rq = migrate_task_rq_fair,
-#endif
+
.rq_online = rq_online_fair,
.rq_offline = rq_offline_fair,
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index cc03cfd..7f36024f 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -227,12 +227,6 @@ struct cfs_rq {
#endif
#ifdef CONFIG_SMP
-/*
- * Load-tracking only depends on SMP, FAIR_GROUP_SCHED dependency below may be
- * removed when useful for applications beyond shares distribution (e.g.
- * load-balance).
- */
-#ifdef CONFIG_FAIR_GROUP_SCHED
/*
* CFS Load tracking
* Under CFS, load is tracked on a per-entity basis and aggregated up.
@@ -242,8 +236,7 @@ struct cfs_rq {
u64 runnable_load_avg, blocked_load_avg;
atomic64_t decay_counter, removed_load;
u64 last_decay;
-#endif /* CONFIG_FAIR_GROUP_SCHED */
-/* These always depend on CONFIG_FAIR_GROUP_SCHED */
+
#ifdef CONFIG_FAIR_GROUP_SCHED
u32 tg_runnable_contrib;
u64 tg_load_contrib;
--
1.7.12
next prev parent reply other threads:[~2013-05-06 1:46 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 1:45 [PATCH v5 0/7] use runnable load avg in load balance Alex Shi
2013-05-06 1:45 ` Alex Shi [this message]
2013-05-06 8:24 ` [PATCH v5 1/7] Revert "sched: Introduce temporary FAIR_GROUP_SCHED dependency for load-tracking" Paul Turner
2013-05-06 8:49 ` Alex Shi
2013-05-06 8:55 ` Paul Turner
2013-05-06 8:58 ` Alex Shi
2013-05-07 5:05 ` Alex Shi
2013-05-06 1:45 ` [PATCH v5 2/7] sched: remove SMP cover for runnable variables in cfs_rq Alex Shi
2013-05-06 4:11 ` Preeti U Murthy
2013-05-06 7:18 ` Alex Shi
2013-05-06 8:01 ` Paul Turner
2013-05-06 8:57 ` Alex Shi
2013-05-06 9:08 ` Paul Turner
2013-05-06 10:47 ` Preeti U Murthy
2013-05-06 15:02 ` Alex Shi
2013-05-07 5:07 ` Alex Shi
2013-05-06 1:45 ` [PATCH v5 3/7] sched: set initial value of runnable avg for new forked task Alex Shi
2013-05-06 8:19 ` Paul Turner
2013-05-06 9:21 ` Alex Shi
2013-05-06 10:17 ` Paul Turner
2013-05-07 2:18 ` Alex Shi
2013-05-07 3:06 ` Paul Turner
2013-05-07 3:24 ` Alex Shi
2013-05-07 5:03 ` Alex Shi
2013-05-09 8:31 ` Alex Shi
2013-05-09 9:30 ` Paul Turner
2013-05-09 14:23 ` Alex Shi
2013-05-08 11:15 ` Peter Zijlstra
2013-05-09 9:34 ` Paul Turner
2013-05-07 9:57 ` Morten Rasmussen
2013-05-07 11:05 ` Alex Shi
2013-05-07 11:20 ` Paul Turner
2013-05-08 11:34 ` Peter Zijlstra
2013-05-08 12:00 ` Paul Turner
2013-05-09 10:55 ` Morten Rasmussen
2013-05-09 8:22 ` Alex Shi
2013-05-09 9:24 ` Paul Turner
2013-05-09 13:13 ` Alex Shi
2013-05-06 10:22 ` Paul Turner
2013-05-06 15:26 ` Alex Shi
2013-05-06 15:28 ` Peter Zijlstra
2013-05-07 2:19 ` Alex Shi
2013-05-06 1:45 ` [PATCH v5 4/7] sched: update cpu load after task_tick Alex Shi
2013-05-06 1:45 ` [PATCH v5 5/7] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task Alex Shi
2013-05-06 8:46 ` Paul Turner
2013-05-06 10:19 ` Peter Zijlstra
2013-05-06 10:33 ` Paul Turner
2013-05-06 11:10 ` Peter Zijlstra
2013-05-07 6:17 ` Alex Shi
2013-06-04 1:45 ` Alex Shi
2013-06-04 1:51 ` [DISCUSSION] removing variety rq->cpu_load ? Alex Shi
2013-06-04 2:33 ` Michael Wang
2013-06-04 2:44 ` Alex Shi
2013-06-04 3:09 ` Michael Wang
2013-06-04 4:55 ` Alex Shi
2013-05-06 15:00 ` [PATCH v5 5/7] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task Alex Shi
2013-05-06 18:34 ` Paul Turner
2013-05-07 0:24 ` Alex Shi
2013-05-07 5:12 ` Alex Shi
2013-05-06 1:45 ` [PATCH v5 6/7] sched: consider runnable load average in move_tasks Alex Shi
2013-05-06 8:53 ` Paul Turner
2013-05-06 15:04 ` Peter Zijlstra
2013-05-06 20:59 ` Paul Turner
2013-05-07 5:17 ` Alex Shi
2013-05-08 1:39 ` Alex Shi
2013-05-09 1:24 ` Alex Shi
2013-05-10 13:58 ` Alex Shi
2013-05-09 5:29 ` Alex Shi
2013-05-10 14:03 ` Alex Shi
2013-05-06 15:07 ` Alex Shi
2013-05-06 1:45 ` [PATCH v5 7/7] sched: consider runnable load average in effective_load Alex Shi
2013-05-06 3:34 ` Michael Wang
2013-05-06 5:39 ` Alex Shi
2013-05-06 6:11 ` Michael Wang
2013-05-06 9:39 ` Alex Shi
2013-05-06 7:49 ` Michael Wang
2013-05-06 8:02 ` Alex Shi
2013-05-06 8:34 ` Michael Wang
2013-05-06 9:06 ` Paul Turner
2013-05-06 9:35 ` Alex Shi
2013-05-06 9:59 ` Preeti U Murthy
2013-05-07 2:43 ` Michael Wang
2013-05-07 5:43 ` Alex Shi
2013-05-08 1:33 ` Alex Shi
2013-05-06 10:00 ` Paul Turner
2013-05-06 7:10 ` Preeti U Murthy
2013-05-06 7:20 ` Michael Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367804711-30308-2-git-send-email-alex.shi@intel.com \
--to=alex.shi@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=preeti@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=wangyun@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome