mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marek Belisko <marek.belisko@gmail.com>
To: mturquette@linaro.org
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, daniel@zonque.org,
	sebastian.hesselbarth@gmail.com,
	Marek Belisko <marek.belisko@streamunlimited.com>
Subject: [PATCH 2/2] clk: si5351: Powerdown output when clock rate is 0.
Date: Tue,  7 May 2013 10:14:51 +0200	[thread overview]
Message-ID: <1367914491-17445-2-git-send-email-marek.belisko@streamunlimited.com> (raw)
In-Reply-To: <1367914491-17445-1-git-send-email-marek.belisko@streamunlimited.com>

When rate is 0 powerdown clock output.

Signed-off-by: Marek Belisko <marek.belisko@streamunlimited.com>
---
 drivers/clk/clk-si5351.c |   32 +++++++++++++++++++-------------
 1 file changed, 19 insertions(+), 13 deletions(-)

diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c
index a8fc0f4..e254e76 100644
--- a/drivers/clk/clk-si5351.c
+++ b/drivers/clk/clk-si5351.c
@@ -1042,20 +1042,22 @@ static int si5351_clkout_set_rate(struct clk_hw *hw, unsigned long rate,
 	struct si5351_hw_data *hwdata =
 		container_of(hw, struct si5351_hw_data, hw);
 	unsigned long new_rate, new_err, err;
-	unsigned char rdiv;
+	unsigned char rdiv, pdn = 0;
 
 	/* round to closed rdiv */
 	rdiv = SI5351_OUTPUT_CLK_DIV_1;
-	new_rate = parent_rate;
-	err = abs(new_rate - rate);
-	do {
-		new_rate >>= 1;
-		new_err = abs(new_rate - rate);
-		if (new_err > err || rdiv == SI5351_OUTPUT_CLK_DIV_128)
-			break;
-		rdiv++;
-		err = new_err;
-	} while (1);
+	if (rate) {
+		new_rate = parent_rate;
+		err = abs(new_rate - rate);
+		do {
+			new_rate >>= 1;
+			new_err = abs(new_rate - rate);
+			if (new_err > err || rdiv == SI5351_OUTPUT_CLK_DIV_128)
+				break;
+			rdiv++;
+			err = new_err;
+		} while (1);
+	}
 
 	/* write output divider */
 	switch (hwdata->num) {
@@ -1075,9 +1077,13 @@ static int si5351_clkout_set_rate(struct clk_hw *hw, unsigned long rate,
 				rdiv << SI5351_OUTPUT_CLK_DIV_SHIFT);
 	}
 
-	/* powerup clkout */
+	/* when rate is 0 powerdown output */
+	if (rate == 0)
+		pdn = SI5351_CLK_POWERDOWN;
+
+	/* powerup/down clkout */
 	si5351_set_bits(hwdata->drvdata, SI5351_CLK0_CTRL + hwdata->num,
-			SI5351_CLK_POWERDOWN, 0);
+			SI5351_CLK_POWERDOWN, pdn);
 
 	dev_dbg(&hwdata->drvdata->client->dev,
 		"%s - %s: rdiv = %u, parent_rate = %lu, rate = %lu\n",
-- 
1.7.9.5


  reply	other threads:[~2013-05-07  8:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-07  8:14 [PATCH 1/2] clk: si5351: Fix msynth_recalc_rate return value when fOUT " Marek Belisko
2013-05-07  8:14 ` Marek Belisko [this message]
2013-05-07 10:07   ` [PATCH 2/2] clk: si5351: Powerdown output when clock rate " Sebastian Hesselbarth
2013-05-07 10:40     ` Marek Belisko
2013-05-07 10:03 ` [PATCH 1/2] clk: si5351: Fix msynth_recalc_rate return value when fOUT " Sebastian Hesselbarth
2013-05-07 10:17   ` Marek Belisko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367914491-17445-2-git-send-email-marek.belisko@streamunlimited.com \
    --to=marek.belisko@gmail.com \
    --cc=daniel@zonque.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marek.belisko@streamunlimited.com \
    --cc=mturquette@linaro.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®