mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Syed Salman Mansoor <syed.salman.mansoor@gmail.com>
To: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	Syed Salman Mansoor <syed.salman.mansoor@gmail.com>
Subject: [PATCH] x86, boot: Cleanup A20 Code
Date: Tue,  7 May 2013 20:58:25 +0500	[thread overview]
Message-ID: <1367942305-32748-1-git-send-email-syed.salman.mansoor@gmail.com> (raw)

Fix checkpatch.pl warnings in a20.c
i)  WARNING: please, no spaces at the start of a line
ii) WARNING: suspect code indent for conditional statements
iii) ERROR: trailing whitespace

Signed-off-by: Syed Salman Mansoor <syed.salman.mansoor@gmail.com>
---
 arch/x86/boot/a20.c |   48 ++++++++++++++++++++++++------------------------
 1 file changed, 24 insertions(+), 24 deletions(-)

diff --git a/arch/x86/boot/a20.c b/arch/x86/boot/a20.c
index 64a31a6..4565f4d 100644
--- a/arch/x86/boot/a20.c
+++ b/arch/x86/boot/a20.c
@@ -129,37 +129,37 @@ static void enable_a20_fast(void)
 
 int enable_a20(void)
 {
-       int loops = A20_ENABLE_LOOPS;
-       int kbc_err;
+	int loops = A20_ENABLE_LOOPS;
+	int kbc_err;
 
-       while (loops--) {
-	       /* First, check to see if A20 is already enabled
+	while (loops--) {
+		/* First, check to see if A20 is already enabled
 		  (legacy free, etc.) */
-	       if (a20_test_short())
-		       return 0;
-	       
+		if (a20_test_short())
+			return 0;
+
 	       /* Next, try the BIOS (INT 0x15, AX=0x2401) */
 	       enable_a20_bios();
-	       if (a20_test_short())
-		       return 0;
-	       
+		if (a20_test_short())
+			return 0;
+
 	       /* Try enabling A20 through the keyboard controller */
 	       kbc_err = empty_8042();
 
-	       if (a20_test_short())
-		       return 0; /* BIOS worked, but with delayed reaction */
-	
-	       if (!kbc_err) {
-		       enable_a20_kbc();
-		       if (a20_test_long())
-			       return 0;
+		if (a20_test_short())
+			return 0; /* BIOS worked, but with delayed reaction */
+
+		if (!kbc_err) {
+			enable_a20_kbc();
+			if (a20_test_long())
+				return 0;
 	       }
-	       
+
 	       /* Finally, try enabling the "fast A20 gate" */
-	       enable_a20_fast();
-	       if (a20_test_long())
-		       return 0;
-       }
-       
-       return -1;
+		enable_a20_fast();
+		if (a20_test_long())
+			return 0;
+	}
+
+	return -1;
 }
-- 
1.7.9.5


             reply	other threads:[~2013-05-07 15:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-07 15:58 Syed Salman Mansoor [this message]
2013-05-07 16:00 ` H. Peter Anvin
2013-05-07 16:05   ` Syed Salman Mansoor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367942305-32748-1-git-send-email-syed.salman.mansoor@gmail.com \
    --to=syed.salman.mansoor@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®