From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: arnd@arndb.de, linus.walleij@stericsson.com,
srinidhi.kasagar@stericsson.com, Lee Jones <lee.jones@linaro.org>
Subject: [PATCH 7/9] pinctrl: abx500: Specify failed sub-driver by ID instead of driver_data
Date: Wed, 8 May 2013 14:29:07 +0100 [thread overview]
Message-ID: <1368019749-19455-8-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1368019749-19455-1-git-send-email-lee.jones@linaro.org>
If a sub-driver has not been specified correctly, there is a good chance
that plat_id is NULL, hence using an attribute of plat_id in the error
message is likely to not only fail the driver but Oops the kernel. Use
the failed ID instead.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/pinctrl/pinctrl-abx500.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-abx500.c b/drivers/pinctrl/pinctrl-abx500.c
index aa17f75..2a2a9df 100644
--- a/drivers/pinctrl/pinctrl-abx500.c
+++ b/drivers/pinctrl/pinctrl-abx500.c
@@ -900,8 +900,7 @@ static int abx500_gpio_probe(struct platform_device *pdev)
abx500_pinctrl_ab8505_init(&pct->soc);
break;
default:
- dev_err(&pdev->dev, "Unsupported pinctrl sub driver (%d)\n",
- (int) platid->driver_data);
+ dev_err(&pdev->dev, "Unsupported pinctrl sub driver (%d)\n", id);
mutex_destroy(&pct->lock);
return -EINVAL;
}
--
1.7.10.4
next prev parent reply other threads:[~2013-05-08 13:30 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 13:29 [PATCH 0/9] Important ux500 fixups due for the v3.10 -rc:s Lee Jones
2013-05-08 13:29 ` [PATCH 1/9] ARM: ux500: Remove duplicated assignment of ab8500_platdata Lee Jones
2013-05-14 8:17 ` Linus Walleij
2013-05-08 13:29 ` [PATCH 2/9] mfd: ab8500-core: Use the correct driver name when enabling gpio/pinctrl Lee Jones
2013-05-14 8:23 ` Linus Walleij
2013-05-08 13:29 ` [PATCH 3/9] clk: ux500: Provide device enumeration number suffix for SMSC911x Lee Jones
2013-05-08 14:00 ` Ulf Hansson
2013-05-14 8:25 ` Linus Walleij
2013-05-14 8:45 ` Lee Jones
2013-06-10 9:08 ` Lee Jones
2013-06-10 9:11 ` Lee Jones
2013-05-14 15:58 ` Mike Turquette
2013-05-15 8:54 ` Linus Walleij
2013-05-15 9:07 ` Lee Jones
2013-05-08 13:29 ` [PATCH 4/9] mfd: db8500-prcmu: Supply the pdata_size attribute for db8500-thermal Lee Jones
2013-05-14 8:25 ` Linus Walleij
2013-05-08 13:29 ` [PATCH 5/9] ARM: ux500: Fix incorrect DEBUG UART virtual addresses Lee Jones
2013-05-14 8:27 ` Linus Walleij
2013-05-08 13:29 ` [PATCH 6/9] ARM: ux500: Provide device enumeration number suffix for SMSC911x Lee Jones
2013-05-14 8:30 ` Linus Walleij
2013-05-14 8:48 ` Lee Jones
2013-05-08 13:29 ` Lee Jones [this message]
2013-05-14 8:35 ` [PATCH 7/9] pinctrl: abx500: Specify failed sub-driver by ID instead of driver_data Linus Walleij
2013-05-08 13:29 ` [PATCH 8/9] pinctrl: abx500: Rejiggle platform data and DT initialisation Lee Jones
2013-05-14 8:40 ` Linus Walleij
2013-05-14 8:47 ` Lee Jones
2013-05-14 8:50 ` Linus Walleij
2013-05-14 9:40 ` Lee Jones
2013-05-14 11:09 ` Linus Walleij
2013-05-08 13:29 ` [PATCH 9/9] mfd: ab8500-core: Pass GPADC compatible string to MFD core Lee Jones
2013-05-14 8:46 ` Linus Walleij
2013-05-14 9:26 ` Lee Jones
2013-05-14 11:06 ` Linus Walleij
2013-05-14 11:34 ` Lee Jones
2013-05-08 13:37 ` [PATCH 0/9] Important ux500 fixups due for the v3.10 -rc:s Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368019749-19455-8-git-send-email-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinidhi.kasagar@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®