From: Denis Efremov <yefremov.denis@gmail.com>
To: "James E.J. Bottomley" <JBottomley@parallels.com>
Cc: Denis Efremov <yefremov.denis@gmail.com>,
Mike Christie <michaelc@cs.wisc.edu>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
trivial@kernel.org, ldv-project@linuxtesting.org
Subject: [PATCH 01/21] [SCSI] libiscsi: remove inline marking of EXPORT_SYMBOL functions
Date: Thu, 9 May 2013 11:58:23 +0400 [thread overview]
Message-ID: <1368086323-9412-1-git-send-email-yefremov.denis@gmail.com> (raw)
In-Reply-To: <1368086241-9357-1-git-send-email-yefremov.denis@gmail.com>
EXPORT_SYMBOL and inline directives are contradictory to each other.
The patch fixes this inconsistency.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
---
drivers/scsi/libiscsi.c | 2 +-
drivers/scsi/libiscsi_tcp.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index 5de9469..8d8d3a5 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -85,7 +85,7 @@ MODULE_PARM_DESC(debug_libiscsi_eh,
__func__, ##arg); \
} while (0);
-inline void iscsi_conn_queue_work(struct iscsi_conn *conn)
+void iscsi_conn_queue_work(struct iscsi_conn *conn)
{
struct Scsi_Host *shost = conn->session->host;
struct iscsi_host *ihost = shost_priv(shost);
diff --git a/drivers/scsi/libiscsi_tcp.c b/drivers/scsi/libiscsi_tcp.c
index 552e8a2..2e37fcc 100644
--- a/drivers/scsi/libiscsi_tcp.c
+++ b/drivers/scsi/libiscsi_tcp.c
@@ -309,7 +309,7 @@ iscsi_tcp_segment_recv(struct iscsi_tcp_conn *tcp_conn,
return copied;
}
-inline void
+void
iscsi_tcp_dgst_header(struct hash_desc *hash, const void *hdr, size_t hdrlen,
unsigned char digest[ISCSI_DIGEST_SIZE])
{
@@ -353,7 +353,7 @@ __iscsi_segment_init(struct iscsi_segment *segment, size_t size,
}
}
-inline void
+void
iscsi_segment_init_linear(struct iscsi_segment *segment, void *data,
size_t size, iscsi_segment_done_fn_t *done,
struct hash_desc *hash)
@@ -364,7 +364,7 @@ iscsi_segment_init_linear(struct iscsi_segment *segment, void *data,
}
EXPORT_SYMBOL_GPL(iscsi_segment_init_linear);
-inline int
+int
iscsi_segment_seek_sg(struct iscsi_segment *segment,
struct scatterlist *sg_list, unsigned int sg_count,
unsigned int offset, size_t size,
@@ -852,7 +852,7 @@ iscsi_tcp_hdr_recv_done(struct iscsi_tcp_conn *tcp_conn,
* returns non zero if we are currently processing or setup to process
* a header.
*/
-inline int iscsi_tcp_recv_segment_is_hdr(struct iscsi_tcp_conn *tcp_conn)
+int iscsi_tcp_recv_segment_is_hdr(struct iscsi_tcp_conn *tcp_conn)
{
return tcp_conn->in.segment.done == iscsi_tcp_hdr_recv_done;
}
--
1.8.1.4
next prev parent reply other threads:[~2013-05-09 7:59 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 7:57 [PATCH 00/21] Exported funtions that are marked inline Denis Efremov
2013-05-09 7:58 ` Denis Efremov [this message]
2013-05-09 7:58 ` [PATCH 02/21] fs: remove inline marking of EXPORT_SYMBOL functions Denis Efremov
2013-05-09 8:07 ` Al Viro
2013-05-09 8:42 ` Denis
2013-05-09 7:58 ` [PATCH 03/21] x86: " Denis Efremov
2013-05-09 13:50 ` H. Peter Anvin
2013-05-09 7:58 ` [PATCH 04/21] NFC: " Denis Efremov
2013-05-09 7:58 ` [PATCH 05/21] 9p: " Denis Efremov
2013-05-09 9:19 ` [PATCH 06/21] staging: nvec: " Denis Efremov
2013-05-09 9:19 ` [PATCH 07/21] netfilter: nf_nat: " Denis Efremov
2013-05-09 9:47 ` David Laight
2013-05-09 9:19 ` [PATCH 08/21] iwlegacy: " Denis Efremov
2013-05-09 9:19 ` [PATCH 09/21] dw_dmac: " Denis Efremov
[not found] ` <CAHp75VfWzzevr6AQzE25P8FUXd=amzL5-XgkJXvbRDESF=M76A@mail.gmail.com>
2013-05-12 15:13 ` Viresh Kumar
2013-05-30 18:01 ` Vinod Koul
2013-05-09 9:19 ` [PATCH 10/21] mm: filemap: " Denis Efremov
2013-05-09 9:19 ` [PATCH 11/21] ipv4: ip_output: " Denis Efremov
2013-05-11 23:13 ` David Miller
2013-05-09 10:36 ` [PATCH 12/21] metag: delay: " Denis Efremov
2013-05-09 11:03 ` James Hogan
2013-05-09 10:36 ` [PATCH 13/21] openrisc: " Denis Efremov
2013-05-09 10:45 ` Will Deacon
2013-05-09 10:36 ` [PATCH 14/21] arm64: " Denis Efremov
2013-05-09 10:39 ` Catalin Marinas
2013-05-09 10:36 ` [PATCH 15/21] arch/tile: " Denis Efremov
2013-05-09 18:02 ` Chris Metcalf
2013-05-09 10:36 ` [PATCH 16/21] sparc: " Denis Efremov
2013-05-09 10:36 ` [PATCH 17/21] CRISv32: " Denis Efremov
2013-05-14 16:35 ` Jesper Nilsson
2013-05-09 10:36 ` [PATCH 18/21] m68k/sun3/: " Denis Efremov
2013-05-09 11:09 ` Geert Uytterhoeven
2013-05-09 10:36 ` [PATCH 19/21] MIPS: MSP71xx: " Denis Efremov
2013-05-09 10:36 ` [PATCH 20/21] powerpc/ps3: " Denis Efremov
2013-05-09 11:35 ` Geoff Levand
2013-05-17 16:05 ` Geert Uytterhoeven
2013-05-28 23:14 ` Geoff Levand
2013-05-09 10:36 ` [PATCH 21/21] ARM: " Denis Efremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368086323-9412-1-git-send-email-yefremov.denis@gmail.com \
--to=yefremov.denis@gmail.com \
--cc=JBottomley@parallels.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®