From: Cong Wang <amwang@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>, Cong Wang <amwang@redhat.com>
Subject: [Patch] quota: do not leak info to user-space
Date: Fri, 10 May 2013 17:24:33 +0800 [thread overview]
Message-ID: <1368177873-4819-1-git-send-email-amwang@redhat.com> (raw)
From: Cong Wang <amwang@redhat.com>
There is a hole in struct fs_quota_stat, so we have to
zero the struct on stack before copying it to user-space.
Cc: Jan Kara <jack@suse.cz>
Signed-off-by: Cong Wang <amwang@redhat.com>
---
diff --git a/fs/quota/quota.c b/fs/quota/quota.c
index c7314f1..2b0c182 100644
--- a/fs/quota/quota.c
+++ b/fs/quota/quota.c
@@ -211,6 +211,7 @@ static int quota_getxstate(struct super_block *sb, void __user *addr)
if (!sb->s_qcop->get_xstate)
return -ENOSYS;
+ memset(&fqs, 0, sizeof(fqs));
ret = sb->s_qcop->get_xstate(sb, &fqs);
if (!ret && copy_to_user(addr, &fqs, sizeof(fqs)))
return -EFAULT;
next reply other threads:[~2013-05-10 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 9:24 Cong Wang [this message]
2013-05-13 10:04 ` Jan Kara
2013-05-13 10:18 ` Jan Kara
2013-05-14 5:33 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368177873-4819-1-git-send-email-amwang@redhat.com \
--to=amwang@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome