From: David Vrabel <david.vrabel@citrix.com>
To: <xen-devel@lists.xen.org>
Cc: David Vrabel <david.vrabel@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
John Stultz <john.stultz@linaro.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH 3/3] x86/xen: sync the CMOS RTC as well as the Xen wallclock
Date: Mon, 13 May 2013 18:56:08 +0100 [thread overview]
Message-ID: <1368467768-2316-4-git-send-email-david.vrabel@citrix.com> (raw)
In-Reply-To: <1368467768-2316-1-git-send-email-david.vrabel@citrix.com>
From: David Vrabel <david.vrabel@citrix.com>
If NTP is used in dom0 and it is synchronized to its clock source,
then the kernel will periodically synchronize the Xen wallclock with
the system time. Updates to the Xen wallclock do not persist across
reboots, so also synchronize the CMOS RTC (as on bare metal).
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
---
arch/x86/xen/time.c | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
index a1947ac..4656165 100644
--- a/arch/x86/xen/time.c
+++ b/arch/x86/xen/time.c
@@ -14,6 +14,7 @@
#include <linux/kernel_stat.h>
#include <linux/math64.h>
#include <linux/gfp.h>
+#include <linux/mc146818rtc.h>
#include <asm/pvclock.h>
#include <asm/xen/hypervisor.h>
@@ -199,17 +200,25 @@ static void xen_get_wallclock(struct timespec *now)
static int xen_set_wallclock(const struct timespec *now)
{
struct xen_platform_op op;
+ int ret;
/* do nothing for domU */
if (!xen_initial_domain())
return -1;
+ /* Set the Xen wallclock. */
op.cmd = XENPF_settime;
op.u.settime.secs = now->tv_sec;
op.u.settime.nsecs = now->tv_nsec;
op.u.settime.system_time = xen_clocksource_read();
- return HYPERVISOR_dom0_op(&op);
+ ret = HYPERVISOR_dom0_op(&op);
+ if (ret)
+ return ret;
+
+ /* Set the hardware RTC. */
+ return mach_set_rtc_mmss(now);
+
}
static struct clocksource xen_clocksource __read_mostly = {
--
1.7.2.5
next prev parent reply other threads:[~2013-05-13 17:57 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 17:56 [PATCH 0/3] x86,time,xen: maintain an accurate persistent clock in more cases David Vrabel
2013-05-13 17:56 ` [PATCH 1/3] x86: increase precision of x86_platform.get/set_wallclock() David Vrabel
2013-05-14 0:57 ` John Stultz
2013-05-14 17:52 ` John Stultz
2013-05-29 0:18 ` John Stultz
2013-05-29 12:16 ` David Vrabel
2013-05-13 17:56 ` [PATCH 2/3] timekeeping: sync persistent clock and RTC on system time step changes David Vrabel
2013-05-14 0:40 ` John Stultz
2013-05-14 9:47 ` David Vrabel
2013-05-14 17:15 ` John Stultz
2013-05-15 8:16 ` [Xen-devel] " Jan Beulich
2013-05-15 18:10 ` John Stultz
2013-05-28 18:26 ` David Vrabel
2013-05-28 18:31 ` Konrad Rzeszutek Wilk
2013-05-28 19:09 ` John Stultz
2013-05-28 19:48 ` Konrad Rzeszutek Wilk
2013-05-28 20:03 ` John Stultz
2013-05-28 20:11 ` John Stultz
2013-05-28 20:25 ` Konrad Rzeszutek Wilk
2013-05-28 20:30 ` John Stultz
2013-05-28 19:06 ` John Stultz
2013-05-13 17:56 ` David Vrabel [this message]
2013-05-14 0:52 ` [PATCH 3/3] x86/xen: sync the CMOS RTC as well as the Xen wallclock John Stultz
2013-05-14 7:57 ` [Xen-devel] " Jan Beulich
2013-05-14 15:59 ` John Stultz
2013-05-14 16:14 ` Jan Beulich
2013-05-14 16:17 ` John Stultz
2013-05-14 16:24 ` Konrad Rzeszutek Wilk
2013-05-14 16:28 ` John Stultz
2013-05-14 9:55 ` David Vrabel
2013-05-14 17:24 ` John Stultz
2013-05-14 18:00 ` David Vrabel
2013-05-14 18:03 ` John Stultz
2013-05-15 8:19 ` [Xen-devel] " Jan Beulich
2013-05-15 18:13 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368467768-2316-4-git-send-email-david.vrabel@citrix.com \
--to=david.vrabel@citrix.com \
--cc=john.stultz@linaro.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome