mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: gregkh@linuxfoundation.org, konrad.wilk@oracle.com,
	chuck.anderson@oracle.com, imammedo@redhat.com
Subject: [RFC 0/2] cpu: fix leak and udev race in register_cpu()
Date: Tue, 14 May 2013 00:05:30 +0200	[thread overview]
Message-ID: <1368482732-25554-1-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <20130513133128.GJ6811@phenom.dumpdata.com>

Here is a crude attempt fix race the way suggested by Greg,
probably done wrong but hopefully in the right direction.

1. move "crash_notes" to static attributes to guarantee that it's
destroyed with CPU on unregister.

2. fixes race between hotplugged CPU and onlining it via udev, described here
https://lkml.org/lkml/2012/4/30/193

Igor Mammedov (2):
  cpu: fix crash_notes leak
  cpu: make sure that cpu/online file created before KOBJ_ADD is
    emitted

 drivers/base/cpu.c |   55 +++++++++++++++++++++++++++++++++++----------------
 1 files changed, 38 insertions(+), 17 deletions(-)


  parent reply	other threads:[~2013-05-13 22:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20120430153623.GA23485@phenom.dumpdata.com>
2012-04-30 15:37 ` udev races with 'arch_register_cpu' to write 1 to /sys/devices/system/cpu/cpu1/online (which is not yet created) Konrad Rzeszutek Wilk
2012-04-30 15:50 ` Greg KH
2012-04-30 15:51   ` Greg KH
2012-04-30 16:17     ` Konrad Rzeszutek Wilk
2013-05-10 16:34       ` Igor Mammedov
2013-05-13 13:31         ` Konrad Rzeszutek Wilk
2013-05-13 14:25           ` Greg KH
2013-05-13 22:05           ` Igor Mammedov [this message]
2013-05-14 13:19             ` [RFC 0/2] cpu: fix leak and udev race in register_cpu() Konrad Rzeszutek Wilk
2013-05-14 14:45             ` Greg KH
2013-05-13 22:05           ` [PATCH 1/2] cpu: fix "crash_notes" leak " Igor Mammedov
2013-05-14 13:16             ` Konrad Rzeszutek Wilk
2013-05-13 22:05           ` [PATCH 2/2] cpu: make sure that cpu/online file created before KOBJ_ADD is emitted Igor Mammedov
2013-05-14 13:17             ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1368482732-25554-1-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=chuck.anderson@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome