mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lad Prabhakar <prabhakar.csengg@gmail.com>
To: LMML <linux-media@vger.kernel.org>,
	uclinux-dist-devel@blackfin.uclinux.org,
	ivtv-devel@ivtvdriver.org
Cc: linux-kernel@vger.kernel.org,
	DLOS <davinci-linux-open-source@linux.davincidsp.com>,
	"Mauro Carvalho Chehab" <mchehab@redhat.com>,
	"Hans Verkuil" <hans.verkuil@cisco.com>,
	"Scott Jiang" <scott.jiang.linux@gmail.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Andy Walls" <awalls@md.metrocast.net>,
	"Mike Isely" <isely@pobox.com>,
	"Devin Heitmueller" <dheitmueller@kernellabs.com>,
	"Guennadi Liakhovetski" <g.liakhovetski@gmx.de>,
	"Antti Palosaari" <crope@iki.fi>,
	"Jon Arne Jørgensen" <jonarne@jonarne.no>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Alexey Klimov" <klimov.linux@gmail.com>,
	"Martin Bugge" <marbugge@cisco.com>,
	"Javier Martin" <javier.martin@vista-silicon.com>,
	"Frank Schäfer" <fschaefer.oss@googlemail.com>,
	"Janne Grunau" <j@jannau.net>,
	"Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Subject: [PATCH 3/4] media: usb: remove duplicate checks for EPERM in vidioc_g/s_register
Date: Tue, 14 May 2013 11:15:16 +0530	[thread overview]
Message-ID: <1368510317-4356-4-git-send-email-prabhakar.csengg@gmail.com> (raw)
In-Reply-To: <1368510317-4356-1-git-send-email-prabhakar.csengg@gmail.com>

From: Lad, Prabhakar <prabhakar.csengg@gmail.com>

This patch removes check for EPERM in vidioc_g/s_register
as this check is already performed by core.

Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
 drivers/media/usb/pvrusb2/pvrusb2-hdw.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
index e11267f..01d1c2d 100644
--- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
+++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
@@ -5173,8 +5173,6 @@ int pvr2_hdw_register_access(struct pvr2_hdw *hdw,
 	int stat = 0;
 	int okFl = 0;
 
-	if (!capable(CAP_SYS_ADMIN)) return -EPERM;
-
 	req.match = *match;
 	req.reg = reg_id;
 	if (setFl) req.val = *val_ptr;
-- 
1.7.4.1


  parent reply	other threads:[~2013-05-14  5:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-14  5:45 [PATCH 0/4] media: remove duplicate check for EPERM Lad Prabhakar
2013-05-14  5:45 ` [PATCH 1/4] media: i2c: remove duplicate checks for EPERM in dbg_g/s_register Lad Prabhakar
2013-05-14  5:45 ` [PATCH 2/4] media: dvb-frontends: " Lad Prabhakar
2013-05-14  5:45 ` Lad Prabhakar [this message]
2013-05-14  5:45 ` [PATCH 4/4] media: pci: remove duplicate checks for EPERM Lad Prabhakar
2013-05-22  5:52 ` [PATCH 0/4] media: remove duplicate check " Prabhakar Lad
2013-05-22  6:47   ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1368510317-4356-4-git-send-email-prabhakar.csengg@gmail.com \
    --to=prabhakar.csengg@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=awalls@md.metrocast.net \
    --cc=corbet@lwn.net \
    --cc=crope@iki.fi \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=dheitmueller@kernellabs.com \
    --cc=fschaefer.oss@googlemail.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=hans.verkuil@cisco.com \
    --cc=isely@pobox.com \
    --cc=ivtv-devel@ivtvdriver.org \
    --cc=j@jannau.net \
    --cc=javier.martin@vista-silicon.com \
    --cc=jonarne@jonarne.no \
    --cc=klimov.linux@gmail.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=marbugge@cisco.com \
    --cc=mchehab@redhat.com \
    --cc=scott.jiang.linux@gmail.com \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®