From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 1/2] nohz: Disable LOCKUP_DETECTOR when NO_HZ_FULL is enabled
Date: Tue, 14 May 2013 18:02:51 +0200 [thread overview]
Message-ID: <1368547372-21011-2-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <1368547372-21011-1-git-send-email-fweisbec@gmail.com>
From: Steven Rostedt <rostedt@goodmis.org>
Trying to test the nohz_full code, I was not able to get it to work.
Finally I enabled the tick_stop tracepoint and it showed:
tick_stop: success=no msg=perf events running
I talked to Frederic Weisbecker about this and he informed me that
perf is used by the lockup detector. I checked the code, and sure
enough it is.
As perf is always running when LOCKUP_DETECTOR is enabled, which
will always disable nohz_full from working, instead of confusing
users, disable LOCKUP_DETECTOR when NO_HZ_FULL is enabled.
When perf is changed such that it does not prevent nohz_full from
working, then we can and should remove this constraint.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
lib/Kconfig.debug | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 566cf2b..1364d09 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -174,6 +174,8 @@ config DEBUG_SHIRQ
config LOCKUP_DETECTOR
bool "Detect Hard and Soft Lockups"
depends on DEBUG_KERNEL && !S390
+ # Lockup detector currently prevents NO_HZ_FULL from working
+ depends on !NO_HZ_FULL
help
Say Y here to enable the kernel to act as a watchdog to detect
hard and soft lockups.
--
1.7.5.4
next prev parent reply other threads:[~2013-05-14 16:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 16:02 [GIT PULL] Nohz fixes Frederic Weisbecker
2013-05-14 16:02 ` Frederic Weisbecker [this message]
2013-05-15 8:37 ` [PATCH 1/2] nohz: Disable LOCKUP_DETECTOR when NO_HZ_FULL is enabled Peter Zijlstra
2013-05-15 15:06 ` Don Zickus
2013-05-15 15:27 ` Steven Rostedt
2013-05-15 16:26 ` Don Zickus
2013-05-15 16:59 ` Peter Zijlstra
2013-05-15 17:04 ` Steven Rostedt
2013-05-16 8:10 ` Peter Zijlstra
2013-05-16 11:38 ` Frederic Weisbecker
2013-05-16 17:57 ` Peter Zijlstra
2013-05-16 15:07 ` Paul E. McKenney
2013-05-16 17:56 ` Peter Zijlstra
2013-05-16 18:32 ` Steven Rostedt
2013-05-16 23:14 ` Frederic Weisbecker
2013-05-19 16:18 ` Paul E. McKenney
2013-05-16 20:06 ` Paul E. McKenney
2013-05-15 17:11 ` Peter Zijlstra
2013-05-15 17:50 ` Don Zickus
2013-05-15 16:55 ` Peter Zijlstra
2013-05-15 15:59 ` Frederic Weisbecker
2013-05-14 16:02 ` [PATCH 2/2] nohz: Warn if the machine can not perform nohz_full Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368547372-21011-2-git-send-email-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®