From: Cody P Schafer <cody@linux.vnet.ibm.com>
To: Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Cody P Schafer <cody@linux.vnet.ibm.com>
Subject: [PATCH v4] checkpatch: avoid warning on page flag acessors
Date: Tue, 14 May 2013 10:17:30 -0700 [thread overview]
Message-ID: <1368551850-7513-1-git-send-email-cody@linux.vnet.ibm.com> (raw)
In-Reply-To: <1368549951-1170-1-git-send-email-cody@linux.vnet.ibm.com>
Using Page*() triggers a camelcase warning, but shouldn't.
be987d9f80354e2e919926349282facd74992f90 added a spurious '"' (double
quote) breaking the regex.
Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
And using sha1s in format-patch means I have to actually copy the new ones. (Again, sorry).
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b954de5..d2fe01d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2939,7 +2939,7 @@ sub process {
my $var = $1;
if ($var !~ /$Constant/ &&
$var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ &&
- $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
+ $var !~ /^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
!defined $camelcase{$var}) {
$camelcase{$var} = 1;
WARN("CAMELCASE",
--
1.8.2.2
prev parent reply other threads:[~2013-05-14 17:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 16:45 [PATCH] " Cody P Schafer
2013-05-14 16:56 ` Cody P Schafer
2013-05-14 17:06 ` [PATCH v2] " Cody P Schafer
2013-05-14 17:13 ` Joe Perches
2013-05-14 17:16 ` Cody P Schafer
2013-05-14 17:08 ` [PATCH v3] " Cody P Schafer
2013-05-14 17:17 ` Cody P Schafer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368551850-7513-1-git-send-email-cody@linux.vnet.ibm.com \
--to=cody@linux.vnet.ibm.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome