From: Corey Minyard <cminyard@mvista.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
OpenIPMI Developers <openipmi-developer@lists.sourceforge.net>,
Alexandru Gheorghiu <gheorghiuandru@gmail.com>,
Corey Minyard <cminyard@mvista.com>
Subject: [PATCH 1/4] drivers: char: ipmi: Replaced kmalloc and strcpy with kstrdup
Date: Thu, 16 May 2013 14:04:24 -0500 [thread overview]
Message-ID: <1368731067-31404-2-git-send-email-cminyard@mvista.com> (raw)
In-Reply-To: <1368731067-31404-1-git-send-email-cminyard@mvista.com>
From: Alexandru Gheorghiu <gheorghiuandru@gmail.com>
Replaced calls to kmalloc followed by strcpy with a sincle call to kstrdup.
Patch found using coccinelle.
Signed-off-by: Alexandru Gheorghiu <gheorghiuandru@gmail.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
---
drivers/char/ipmi/ipmi_msghandler.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index 4d439d2..4445fa1 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -2037,12 +2037,11 @@ int ipmi_smi_add_proc_entry(ipmi_smi_t smi, char *name,
entry = kmalloc(sizeof(*entry), GFP_KERNEL);
if (!entry)
return -ENOMEM;
- entry->name = kmalloc(strlen(name)+1, GFP_KERNEL);
+ entry->name = kstrdup(name, GFP_KERNEL);
if (!entry->name) {
kfree(entry);
return -ENOMEM;
}
- strcpy(entry->name, name);
file = proc_create_data(name, 0, smi->proc_dir, proc_ops, data);
if (!file) {
--
1.7.9.5
next prev parent reply other threads:[~2013-05-16 20:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 19:04 [PATCH 0/4] ipmi: Some minor fixes Corey Minyard
2013-05-16 19:04 ` Corey Minyard [this message]
2013-05-16 19:04 ` [PATCH 2/4] drivers/char/ipmi: memcpy, need additional 2 bytes to avoid memory overflow Corey Minyard
2013-05-16 19:04 ` [PATCH 3/4] ipmi: Improve error messages on failed irq enable Corey Minyard
2013-05-16 22:23 ` Andy Lutomirski
2013-05-17 3:47 ` Corey Minyard
2013-05-17 4:57 ` Joe Perches
2013-05-16 19:04 ` [PATCH 4/4] ipmi: ipmi_devintf: compat_ioctl method fails to take ipmi_mutex Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368731067-31404-2-git-send-email-cminyard@mvista.com \
--to=cminyard@mvista.com \
--cc=gheorghiuandru@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®