From: Ben Hutchings <bhutchings@solarflare.com>
To: Sriram Narasimhan <sriram.narasimhan@hp.com>
Cc: <mst@redhat.com>, <rusty@rustcorp.com.au>,
<virtualization@lists.linux-foundation.org>,
<kvm@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] virtio-net: Reporting traffic queue distribution statistics through ethtool
Date: Thu, 16 May 2013 22:47:35 +0100 [thread overview]
Message-ID: <1368740855.2655.57.camel@bwh-desktop.uk.solarflarecom.com> (raw)
In-Reply-To: <1368735869-31076-1-git-send-email-sriram.narasimhan@hp.com>
On Thu, 2013-05-16 at 13:24 -0700, Sriram Narasimhan wrote:
> This patch allows virtio-net driver to report traffic distribution
> to inbound/outbound queues through ethtool -S. The per_cpu
> virtnet_stats is split into receive and transmit stats and are
> maintained on a per receive_queue and send_queue basis.
> virtnet_stats() is modified to aggregate interface level statistics
> from per-queue statistics. Sample output below:
>
> NIC statistics:
> rxq0: rx_packets: 4357802
> rxq0: rx_bytes: 292642052
> txq0: tx_packets: 824540
> txq0: tx_bytes: 55256404
> rxq1: rx_packets: 0
> rxq1: rx_bytes: 0
> txq1: tx_packets: 1094268
> txq1: tx_bytes: 73328316
> rxq2: rx_packets: 0
> rxq2: rx_bytes: 0
> txq2: tx_packets: 1091466
> txq2: tx_bytes: 73140566
> rxq3: rx_packets: 0
> rxq3: rx_bytes: 0
> txq3: tx_packets: 1093043
> txq3: tx_bytes: 73246142
>
> Signed-off-by: Sriram Narasimhan <sriram.narasimhan@hp.com>
[...]
That ordering is totally unreadable. I want to see patches for ethtool
to let the user order and aggregate the queue statistics in a sensible
way:
$ ethtool -S eth0 # default would show aggregated statistics
NIC statistics:
rx_packets: 4357802
rx_bytes: 292642052
tx_packets: 4103317
tx_bytes: 274971428
$ ethtool -S eth0 full group queue # full statistics, grouped by queue name
NIC statistics:
rxq0:
rx_packets: 4357802
rx_bytes: 292642052
rxq1:
rx_packets: 0
rx_bytes: 0
[...]
txq0:
tx_packets: 824540
tx_bytes: 55256404
txq1:
tx_packets: 1094268
tx_bytes: 73328316
[...]
$ ethtool -S eth0 full group statistic # full statistics, grouped by statistic name
NIC statistics:
rx_packets:
rxq0: 4357802
rxq1: 0
rxq2: 0
rxq3: 0
rx_bytes:
rxq0: 292642052
rxq1: 0
rxq2: 0
rxq3: 0
[...]
Maybe even:
$ ethtool -S eth0 full table
NIC statistics:
rx_packets rx_bytes
rxq0: 4357802 292642052
rxq1: 0 0
rxq2: 0 0
rxq3: 0 0
tx_packets tx_bytes
txq0: 824540 55256404
txq1: 1094268 73328316
txq2: 1091466 73140566
txq3: 1093043 73246142
(Difficult to do, but probably very useful!)
The queue names should be rx-<index> and tx-<index> like in sysfs.
We'll need to reach a consensus on the naming scheme for per-queue and
otherwise disaggregated statistics (see previous discussions in
<http://thread.gmane.org/gmane.linux.kernel.virtualization/15572/focus=15608>). I don't much care what they look like as long as there's an implementation for the ethtool side and they don't look too awful in older versions of ethtool.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2013-05-16 21:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 20:24 Sriram Narasimhan
2013-05-16 21:47 ` Ben Hutchings [this message]
2013-05-17 2:42 ` Narasimhan, Sriram
2013-05-19 11:28 ` Michael S. Tsirkin
2013-05-19 16:09 ` Narasimhan, Sriram
2013-05-19 20:03 ` Michael S. Tsirkin
2013-05-19 22:56 ` Narasimhan, Sriram
2013-05-20 3:28 ` Jason Wang
2013-05-20 9:59 ` Michael S. Tsirkin
2013-05-21 1:26 ` Narasimhan, Sriram
2013-05-21 5:11 ` Jason Wang
2013-05-21 8:35 ` Michael S. Tsirkin
2013-07-11 16:33 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368740855.2655.57.camel@bwh-desktop.uk.solarflarecom.com \
--to=bhutchings@solarflare.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=sriram.narasimhan@hp.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®