From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Jaegeuk Kim <jaegeuk.kim@samsung.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: [PATCH 01/15] f2fs: remove redundant assignment
Date: Mon, 20 May 2013 12:32:15 +0900 [thread overview]
Message-ID: <1369020743-18520-1-git-send-email-jaegeuk.kim@samsung.com> (raw)
We don't need to assign a value redundantly.
Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
---
fs/f2fs/recovery.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
index 60c8a50..2941987 100644
--- a/fs/f2fs/recovery.c
+++ b/fs/f2fs/recovery.c
@@ -126,7 +126,6 @@ static int find_fsync_dnodes(struct f2fs_sb_info *sbi, struct list_head *head)
entry = get_fsync_inode(head, ino_of_node(page));
if (entry) {
- entry->blkaddr = blkaddr;
if (IS_INODE(page) && is_dent_dnode(page))
set_inode_flag(F2FS_I(entry->inode),
FI_INC_LINK);
@@ -150,10 +149,10 @@ static int find_fsync_dnodes(struct f2fs_sb_info *sbi, struct list_head *head)
kmem_cache_free(fsync_entry_slab, entry);
goto unlock_out;
}
-
list_add_tail(&entry->list, head);
- entry->blkaddr = blkaddr;
}
+ entry->blkaddr = blkaddr;
+
if (IS_INODE(page)) {
err = recover_inode(entry->inode, page);
if (err == -ENOENT) {
--
1.8.1.3.566.gaa39828
next reply other threads:[~2013-05-20 3:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 3:32 Jaegeuk Kim [this message]
2013-05-20 3:32 ` [PATCH 02/15] f2fs: remove unnecessary flag set Jaegeuk Kim
2013-05-20 7:31 ` Jaegeuk Kim
2013-05-20 3:32 ` [PATCH 03/15] f2fs: fix por_doing variable coverage Jaegeuk Kim
2013-05-20 3:32 ` [PATCH 04/15] f2fs: fix BUG_ON during f2fs_evict_inode(dir) Jaegeuk Kim
2013-05-20 3:32 ` [PATCH 05/15] f2fs: remove unnecessary por_doing check Jaegeuk Kim
2013-05-20 3:32 ` [PATCH 06/15] f2fs: skip get_node_page if locked node page is passed Jaegeuk Kim
2013-05-20 3:32 ` [PATCH 07/15] f2fs: change get_new_data_page to pass a locked node page Jaegeuk Kim
2013-05-20 3:32 ` [PATCH 08/15] f2fs: update inode page after creation Jaegeuk Kim
2013-05-20 3:32 ` [PATCH 09/15] f2fs: add debug msgs in the recovery routine Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369020743-18520-1-git-send-email-jaegeuk.kim@samsung.com \
--to=jaegeuk.kim@samsung.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®