From: johnlinn@comcast.net
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
alan@lxorguk.ukuu.org.uk,
michal simek <michal.simek@petalogix.com>,
joe@perches.com, grant likely <grant.likely@secretlab.ca>,
John Linn <john.linn@xilinx.com>
Subject: Re: [PATCH V4] tty/serial: add support for Xilinx PS UART
Date: Fri, 29 Apr 2011 22:02:39 +0000 (UTC) [thread overview]
Message-ID: <1369027353.2095897.1304114559625.JavaMail.root@sz0140a.emeryville.ca.mail.comcast.net> (raw)
In-Reply-To: <20110429211434.GA1355@kroah.com>
> On Wed, Apr 27, 2011 at 12:17:36PM -0600, johnlinn@comcast.net wrote:
> > From: John Linn <john.linn@xilinx.com>
> >
> > The Xilinx PS Uart is used on the new ARM based SoC. This
> > UART is not compatible with others such that a seperate
> > driver is required.
> >
> > Signed-off-by: John Linn <john.linn@xilinx.com>
>
> I get build failures with this patch:
>
> CC [M] drivers/tty/serial/xilinx_uartps.o
> drivers/tty/serial/xilinx_uartps.c: In function ‘xuartps_get_port’:
> drivers/tty/serial/xilinx_uartps.c:785:14: error: ‘NO_IRQ’ undeclared
> (first use in this function)
> drivers/tty/serial/xilinx_uartps.c:785:14: note: each undeclared
> identifier is reported only once for each function it appears in
> make[1]: *** [drivers/tty/serial/xilinx_uartps.o] Error 1
>
> Care to fix this up so it's in a state I can properly apply it to the
> tree?
>
> thanks,
>
> greg k-h
Done and sent out as V5 of patch.
Just for future reference (and maybe I should know this). How should I
have prevented this problem? I guess I would need to build the kernel
for other architectures and I don't normally do that.
Thanks,
John
next prev parent reply other threads:[~2011-04-29 22:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 18:17 johnlinn
2011-04-27 20:40 ` Alan Cox
2011-04-27 20:57 ` johnlinn
2011-04-29 21:14 ` Greg KH
2011-04-29 21:29 ` johnlinn
2011-04-29 21:32 ` Alan Cox
2011-04-29 21:41 ` johnlinn
2011-05-06 12:11 ` Michal Simek
2011-05-06 12:23 ` Alan Cox
2011-05-06 16:41 ` Grant Likely
2011-04-29 22:02 ` johnlinn [this message]
2011-04-29 23:29 ` Greg KH
[not found] <681890114.2094084.1304112868616.JavaMail.root@sz0140a.emeryville.ca.mail.comcast.net>
2011-04-29 21:35 ` johnlinn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369027353.2095897.1304114559625.JavaMail.root@sz0140a.emeryville.ca.mail.comcast.net \
--to=johnlinn@comcast.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=grant.likely@secretlab.ca \
--cc=greg@kroah.com \
--cc=joe@perches.com \
--cc=john.linn@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@petalogix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®