From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: eliezer.tamir@linux.intel.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, jesse.brandeburg@intel.com,
donanld.c.skidmore@intel.com, e1000-devel@lists.sourceforge.net,
willemb@google.com, andi@firstfloor.org, hpa@zytor.com,
eliezer@tamir.org.il
Subject: Re: [PATCH v2 net-next 1/4] net: implement support for low latency socket polling
Date: Mon, 20 May 2013 01:29:47 -0700 [thread overview]
Message-ID: <1369038587.2143.12.camel@joe-AO722> (raw)
In-Reply-To: <20130520.005447.972811583292360876.davem@davemloft.net>
On Mon, 2013-05-20 at 00:54 -0700, David Miller wrote:
> From: Eliezer Tamir <eliezer.tamir@linux.intel.com>
[]
> > {
> > struct socket *sock;
> > + unsigned int poll_result;
>
> Please order local variable declarations from longest line to
> shortest line.
reverse christmas tree doesn't seem especially valuable or
sensible for automatics.
I'd rather order by first use or even alphabetical, especially
with long lists of automatics.
next prev parent reply other threads:[~2013-05-20 8:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-19 10:25 [PATCH v2 net-next 0/4] net: low latency Ethernet device polling Eliezer Tamir
2013-05-19 10:25 ` [PATCH v2 net-next 1/4] net: implement support for low latency socket polling Eliezer Tamir
2013-05-20 7:54 ` David Miller
2013-05-20 8:29 ` Joe Perches [this message]
2013-05-20 9:16 ` David Miller
2013-05-20 9:39 ` Eliezer Tamir
2013-05-20 19:34 ` David Miller
2013-05-20 16:22 ` Andi Kleen
2013-05-21 6:16 ` Eliezer Tamir
2013-05-19 10:25 ` [PATCH v2 net-next 2/4] tcp: add TCP support for low latency receive poll Eliezer Tamir
2013-05-19 10:25 ` [PATCH v2 net-next 3/4] ixgbe: Add support for ndo_ll_poll Eliezer Tamir
2013-05-19 10:26 ` [PATCH v2 net-next 4/4] ixgbe: add extra stats " Eliezer Tamir
2013-05-19 19:06 ` [PATCH v2 net-next 0/4] net: low latency Ethernet device polling Or Gerlitz
2013-05-19 19:20 ` Eliezer Tamir
2013-05-20 20:09 ` [E1000-devel] " Jeff Kirsher
2013-05-19 19:25 ` Eliezer Tamir
[not found] ` <CAJZOPZ+8zKfuuUhOwzz6WKm6do6N25B1DAmv+aOipSLbvdh6LA@mail.gmail.com>
2013-05-20 10:26 ` Eliezer Tamir
2013-05-20 22:44 ` Brandeburg, Jesse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369038587.2143.12.camel@joe-AO722 \
--to=joe@perches.com \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=donanld.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eliezer.tamir@linux.intel.com \
--cc=eliezer@tamir.org.il \
--cc=hpa@zytor.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®