From: "Eilon Greenstein" <eilong@broadcom.com>
To: "Or Gerlitz" <or.gerlitz@gmail.com>
Cc: "Eliezer Tamir" <eliezer.tamir@linux.intel.com>,
"Dave Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
"Don Skidmore" <donald.c.skidmore@intel.com>,
e1000-devel@lists.sourceforge.net,
"Willem de Bruijn" <willemb@google.com>,
"Andi Kleen" <andi@firstfloor.org>, HPA <hpa@zytor.com>,
"Eliezer Tamir" <eliezer@tamir.org.il>
Subject: Re: [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll_poll
Date: Tue, 21 May 2013 11:28:49 +0300 [thread overview]
Message-ID: <1369124929.29989.0.camel@lb-tlvb-eilong.il.broadcom.com> (raw)
In-Reply-To: <CAJZOPZKzTk+zJ2z0Bv9y1iZRdXb842z_WG8E3jNCoHw0C3fhQQ@mail.gmail.com>
On Tue, 2013-05-21 at 11:21 +0300, Or Gerlitz wrote:
> On Tue, May 21, 2013 at 10:06 AM, Eilon Greenstein <eilong@broadcom.com> wrote:
> > Or - at least for the bnx2x, it is easy to add support for this new ndo.
>
> Do you understand what's the equivalent of that mysterious module
> param for your driver/HW - or you just copied and pasted that black
> magic code?
>
The module parameter is not the interesting part of this patch. It is
clear that unloading the module while this sort of traffic is running is
not safe and the alternative of adding a reference count or something
similar sounds too costly (after all, this patch is about performance).
I just played with it to get a feel of the latency improvement - I did
not try unloading the module during traffic so I do not care about the
module parameter part right now. I agree that the unload should be
looked into - but the general concept is great and it is a very nice
improvement.
next prev parent reply other threads:[~2013-05-21 8:29 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 10:15 [PATCH v3 net-next 0/4] net: low latency Ethernet device polling Eliezer Tamir
2013-05-20 10:16 ` [PATCH v3 net-next 1/4] net: implement support for low latency socket polling Eliezer Tamir
2013-05-20 15:29 ` Eric Dumazet
2013-05-20 19:40 ` David Miller
2013-05-21 7:28 ` Eliezer Tamir
2013-05-21 13:28 ` Eric Dumazet
2013-05-21 17:02 ` Pekka Riikonen
2013-05-21 17:48 ` Eric Dumazet
2013-05-21 17:51 ` Eric Dumazet
2013-05-21 19:25 ` Eliezer Tamir
2013-05-21 19:29 ` Eric Dumazet
2013-05-21 18:49 ` David Miller
2013-05-21 19:31 ` Pekka Riikonen
2013-05-20 10:16 ` [PATCH v3 net-next 2/4] tcp: add TCP support for low latency receive poll Eliezer Tamir
2013-05-20 13:49 ` Eric Dumazet
2013-05-20 14:59 ` Eliezer Tamir
2013-05-20 10:16 ` [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll_poll Eliezer Tamir
2013-05-20 20:20 ` Or Gerlitz
2013-05-20 20:33 ` Andi Kleen
[not found] ` <CAJZOPZJwcgShs-FCaXmPmigdu55ZSt08WnJjadcOi+-_AMq=oA@mail.gmail.com>
2013-05-20 21:01 ` Andi Kleen
2013-05-21 6:23 ` Or Gerlitz
2013-05-21 6:54 ` Eliezer Tamir
2013-05-21 7:06 ` Eilon Greenstein
2013-05-21 7:14 ` David Miller
2013-05-21 8:24 ` Or Gerlitz
2013-05-21 8:31 ` Eliezer Tamir
2013-05-21 8:39 ` David Miller
2013-05-21 8:42 ` Eliezer Tamir
2013-05-21 8:43 ` Or Gerlitz
2013-05-21 10:27 ` Eliezer Tamir
2013-05-21 10:41 ` Or Gerlitz
2013-05-21 8:21 ` Or Gerlitz
2013-05-21 8:28 ` Eilon Greenstein [this message]
2013-05-21 14:19 ` Willem de Bruijn
2013-05-20 10:16 ` [PATCH v3 net-next 4/4] ixgbe: add extra stats " Eliezer Tamir
2013-05-21 12:06 ` [PATCH v3 net-next 0/4] net: low latency Ethernet device polling Alex Rosenbaum
2013-05-21 12:29 ` Eliezer Tamir
2013-05-21 13:15 ` Alex Rosenbaum
2013-05-21 13:31 ` Eric Dumazet
2013-05-23 11:06 ` Eliezer Tamir
2013-05-21 14:30 ` Willem de Bruijn
2013-05-21 18:15 ` Ben Hutchings
2013-05-22 9:35 ` Eliezer Tamir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369124929.29989.0.camel@lb-tlvb-eilong.il.broadcom.com \
--to=eilong@broadcom.com \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eliezer.tamir@linux.intel.com \
--cc=eliezer@tamir.org.il \
--cc=hpa@zytor.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®