From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752748Ab3EUNyT (ORCPT ); Tue, 21 May 2013 09:54:19 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:35911 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785Ab3EUNyR (ORCPT ); Tue, 21 May 2013 09:54:17 -0400 Message-ID: <1369144440.3469.181.camel@deadeye.wl.decadent.org.uk> Subject: Re: [PATCH 0/5] perf: net_dropmonitor: Make it work and make it fast From: Ben Hutchings To: Neil Horman Cc: Peter Zijlstra , Paul Mackerras , Ingo Molnar , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 21 May 2013 14:54:00 +0100 In-Reply-To: <20130521133355.GA3613@neilslaptop.think-freely.org> References: <1369096976.3469.131.camel@deadeye.wl.decadent.org.uk> <20130521133355.GA3613@neilslaptop.think-freely.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-+T9vp5LhkE5Kws61d6IM" X-Mailer: Evolution 3.4.4-2 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.4.101 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-+T9vp5LhkE5Kws61d6IM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2013-05-21 at 09:33 -0400, Neil Horman wrote: > On Tue, May 21, 2013 at 01:42:56AM +0100, Ben Hutchings wrote: > > Somewhat surprisingly, the net_dropmonitor reporting script doesn't wor= k > > at all. This series fixes it and then makes it slightly more efficient= . > >=20 > > Ben. > >=20 > It worked fine when I first submitted it. I wonder if there was a paramt= er > order change at some point that I wasn't CC'ed on. The parameter order for the trace event changed in 2.6.39, but that was before this script went in. Ben. > Either way, this all looks good. Thanks Ben. >=20 > Acked-by: Neil Horman >=20 > > Ben Hutchings (5): > > perf: net_dropmonitor: Fix trace parameter order > > perf: net_dropmonitor: Fix symbol-relative addresses > > perf: net_dropmonitor: Do not assume ordering of dictionaries > > perf: net_dropmonitor: Use bisection in symbol lookup > > perf: net_dropmonitor: Remove progress indicator > >=20 > > tools/perf/scripts/python/net_dropmonitor.py | 39 ++++++++++++++----= -------- > > 1 file changed, 21 insertions(+), 18 deletions(-) > >=20 > >=20 >=20 >=20 --=20 Ben Hutchings friends: People who know you well, but like you anyway. --=-+T9vp5LhkE5Kws61d6IM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIVAwUAUZt8eOe/yOyVhhEJAQo7gA/9FLWw7cJaA1v1e5mRcI7lZQlHAPaVc1iK WhaFNqw2QNl+ssqO7xJWvNR1WpVNe/pBPI38dF7iHcVW04KmXBh6dNzSpZN0X67y 9Tb5xaPjJTLYF8MVAzUE18L4tE/I7+ZZaaaDD6Xm7SQEyr0DTvG0T5pGIpM10Dqo uhk3O9hQzQzcx/M3aG3sz061Z7QU8JIViJmg72fnxVS55oV1vYVFobkG6hNwoB8C 8iOamGCGiCOW4yCoW8lAmkpXi7AfbdKvRoiQ6NVLFXhk3qU9H4AHPrcvc+JIpGWs 3BySblSl1TvLEYGpseMy2uCy7HDms9kksMELc/Q4v1ARZnETI6d3AmExJ/vV0Qr+ jpPnco73M5LMedyO/X/XP9HAcoD+Lzg/T8n9MRFvaeebElnEA/4rrjwHU2gExy7+ efvjtD585Jvs4U4Pbd8ujev6767rKrh2kvKBNpivSyf8cVP+UPspRqwvfpp8XvMK 1pMMJDzIb12Ei6WFdOm32OAXquWdE4JqNbf8dItUvk9pn5lVfj7MzDwDcOigEvZ8 PXrDUU55fC6jmUFOuMgWYriJjYwfSMLnLAK7U9Mf9VWWOrsSeAaQfpf+Lg9X16lD bIazFY6C06piMRq5elEh497JuQmOo+InHAWwTq4cwhClEc9nwrp3/I0MHDmztumf /vzLwJZ5wj8= =88Sp -----END PGP SIGNATURE----- --=-+T9vp5LhkE5Kws61d6IM--