From: Ben Hutchings <bhutchings@solarflare.com>
To: Eliezer Tamir <eliezer.tamir@linux.intel.com>
Cc: Dave Miller <davem@davemloft.net>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
"Don Skidmore" <donald.c.skidmore@intel.com>,
<e1000-devel@lists.sourceforge.net>,
Willem de Bruijn <willemb@google.com>,
Andi Kleen <andi@firstfloor.org>, HPA <hpa@zytor.com>,
Or Gerlitz <or.gerlitz@gmail.com>,
Eilon Greenstien <eilong@broadcom.com>,
Eliezer Tamir <eliezer@tamir.org.il>
Subject: Re: [PATCH v4 net-next 1/4] net: implement support for low latency socket polling
Date: Tue, 21 May 2013 18:23:50 +0100 [thread overview]
Message-ID: <1369157030.2615.24.camel@bwh-desktop.uk.solarflarecom.com> (raw)
In-Reply-To: <20130521142650.18498.71715.stgit@ladj378.jer.intel.com>
On Tue, 2013-05-21 at 17:26 +0300, Eliezer Tamir wrote:
> Adds a new ndo_ll_poll method and the code that supports and uses it.
> This method can be used by low latency applications to busy poll ethernet
> device queues directly from the socket code. The ip_low_latency_poll sysctl
> entry controls how many cycles to poll. Set to zero to disable.
Microseconds, not cycles.
[...]
> --- a/Documentation/networking/ip-sysctl.txt
> +++ b/Documentation/networking/ip-sysctl.txt
> @@ -19,6 +19,12 @@ ip_no_pmtu_disc - BOOLEAN
> Disable Path MTU Discovery.
> default FALSE
>
> +ip_low_latency_poll - INTEGER
> + Low latency busy poll timeout. (needs CONFIG_INET_LL_RX_POLL)
> + Approximate time in ms to spin waiting for packets on the device queue.
us, not ms.
[...]
> --- /dev/null
> +++ b/include/net/ll_poll.h
> @@ -0,0 +1,117 @@
> +/*
> + * low latency network device queue flush
> + * Copyright(c) 2013 Intel Corporation.
> + * Author: Eliezer Tamir
> + *
> + * For now this depends on CONFIG_I86_TSC
CONFIG_X86_TSC
[...]
> +static inline bool sk_poll_ll(struct sock *sk, int nonblock)
> +{
> + unsigned long end_time = TSC_MHZ * ACCESS_ONCE(sysctl_net_ll_poll)
> + + get_cycles();
> + struct napi_struct *napi = sk->dev_ref;
> + const struct net_device_ops *ops;
> + int rc;
> +
> + if (!napi->dev->netdev_ops->ndo_ll_poll)
> + return false;
> +
> + local_bh_disable();
> +
> + ops = napi->dev->netdev_ops;
Should be done before testing ndo_ll_poll above, so you can avoid
repeating the indirections.
> + while (skb_queue_empty(&sk->sk_receive_queue) &&
> + !time_after((unsigned long)get_cycles(), end_time)) {
> + rc = ops->ndo_ll_poll(napi);
> +
> + if (rc == LL_FLUSH_FAILED)
> + break; /* premanent failure */
[...]
Typo: 'permanent'.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2013-05-21 17:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 14:26 [PATCH v4 net-next 0/4] net: low latency Ethernet device polling Eliezer Tamir
2013-05-21 14:26 ` [PATCH v4 net-next 1/4] net: implement support for low latency socket polling Eliezer Tamir
2013-05-21 14:35 ` Eric Dumazet
2013-05-21 17:23 ` Ben Hutchings [this message]
2013-05-21 17:28 ` Eliezer Tamir
2013-05-21 17:27 ` Ben Hutchings
2013-05-21 14:27 ` [PATCH v4 net-next 2/4] tcp: add TCP support for low latency receive poll Eliezer Tamir
2013-05-21 17:30 ` Ben Hutchings
2013-05-21 14:27 ` [PATCH v4 net-next 3/4] ixgbe: Add support for ndo_ll_poll Eliezer Tamir
2013-05-21 17:33 ` Ben Hutchings
2013-05-21 14:27 ` [PATCH v4 net-next 4/4] ixgbe: add extra stats " Eliezer Tamir
2013-05-23 11:00 ` [PATCH v4 net-next 0/4] net: low latency Ethernet device polling Alex Rosenbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369157030.2615.24.camel@bwh-desktop.uk.solarflarecom.com \
--to=bhutchings@solarflare.com \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eilong@broadcom.com \
--cc=eliezer.tamir@linux.intel.com \
--cc=eliezer@tamir.org.il \
--cc=hpa@zytor.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®