From: Peter Huewe <peterhuewe@gmx.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Hans J. Koch" <hjk@hansjkoch.de>,
linux-kernel@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>
Subject: [PATCH v2] uio/uio_pci_generic: Use module_pci_driver to register driver
Date: Tue, 21 May 2013 22:47:44 +0200 [thread overview]
Message-ID: <1369169264-13144-1-git-send-email-peterhuewe@gmx.de> (raw)
In-Reply-To: <20130521170952.GA6895@kroah.com>
Removing some boilerplate by using module_pci_driver instead of calling
register and unregister in the otherwise empty init/exit functions.
It removes a pr_info showing some details about the driver, but
these infos can also be retrieved by using modinfo.
The name of the pci_driver struct had to be changed in order to prevent a
build failure.
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
Sorry for the build failure.
drivers/uio/uio_pci_generic.c | 17 ++---------------
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c
index 14aa10c..077ae12 100644
--- a/drivers/uio/uio_pci_generic.c
+++ b/drivers/uio/uio_pci_generic.c
@@ -113,27 +113,14 @@ static void remove(struct pci_dev *pdev)
kfree(gdev);
}
-static struct pci_driver driver = {
+static struct pci_driver uio_pci_driver = {
.name = "uio_pci_generic",
.id_table = NULL, /* only dynamic id's */
.probe = probe,
.remove = remove,
};
-static int __init init(void)
-{
- pr_info(DRIVER_DESC " version: " DRIVER_VERSION "\n");
- return pci_register_driver(&driver);
-}
-
-static void __exit cleanup(void)
-{
- pci_unregister_driver(&driver);
-}
-
-module_init(init);
-module_exit(cleanup);
-
+module_pci_driver(uio_pci_driver);
MODULE_VERSION(DRIVER_VERSION);
MODULE_LICENSE("GPL v2");
MODULE_AUTHOR(DRIVER_AUTHOR);
--
1.8.1.5
prev parent reply other threads:[~2013-05-21 20:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 20:47 [PATCH 1/5] uio/uio_aec: " Peter Huewe
2013-05-20 20:47 ` [PATCH 2/5] uio/uio_cif: " Peter Huewe
2013-05-20 20:47 ` [PATCH 3/5] uio/uio_netx: " Peter Huewe
2013-05-20 20:47 ` [PATCH 4/5] uio/uio_sercos3: " Peter Huewe
2013-05-20 20:47 ` [PATCH 5/5] uio/uio_pci_generic: " Peter Huewe
2013-05-21 17:09 ` Greg Kroah-Hartman
2013-05-21 20:47 ` Peter Huewe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369169264-13144-1-git-send-email-peterhuewe@gmx.de \
--to=peterhuewe@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=hjk@hansjkoch.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®