From: Peter Huewe <peterhuewe@gmx.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: Peter Huewe <peterhuewe@gmx.de>,
David Decotigny <decot@googlers.com>,
Jiri Pirko <jiri@resnulli.us>,
Ben Hutchings <bhutchings@solarflare.com>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org (open list:NETWORKING DRIVERS),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 19/19] net/ethernet/nvidia/forcedeth: Use module_pci_driver to register driver
Date: Wed, 22 May 2013 01:42:56 +0200 [thread overview]
Message-ID: <1369179778-20115-19-git-send-email-peterhuewe@gmx.de> (raw)
In-Reply-To: <1369176146-19383-1-git-send-email-peterhuewe@gmx.de>
Removing some boilerplate by using module_pci_driver instead of calling
register and unregister in the otherwise empty init/exit functions.
The name of the pci_driver struct had to be changed in order to prevent
a build failure.
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
drivers/net/ethernet/nvidia/forcedeth.c | 17 ++---------------
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c
index b003fe5..098b96d 100644
--- a/drivers/net/ethernet/nvidia/forcedeth.c
+++ b/drivers/net/ethernet/nvidia/forcedeth.c
@@ -6340,7 +6340,7 @@ static DEFINE_PCI_DEVICE_TABLE(pci_tbl) = {
{0,},
};
-static struct pci_driver driver = {
+static struct pci_driver forcedeth_pci_driver = {
.name = DRV_NAME,
.id_table = pci_tbl,
.probe = nv_probe,
@@ -6349,16 +6349,6 @@ static struct pci_driver driver = {
.driver.pm = NV_PM_OPS,
};
-static int __init init_nic(void)
-{
- return pci_register_driver(&driver);
-}
-
-static void __exit exit_nic(void)
-{
- pci_unregister_driver(&driver);
-}
-
module_param(max_interrupt_work, int, 0);
MODULE_PARM_DESC(max_interrupt_work, "forcedeth maximum events handled per interrupt");
module_param(optimization_mode, int, 0);
@@ -6379,11 +6369,8 @@ module_param(debug_tx_timeout, bool, 0);
MODULE_PARM_DESC(debug_tx_timeout,
"Dump tx related registers and ring when tx_timeout happens");
+module_pci_driver(forcedeth_pci_driver);
MODULE_AUTHOR("Manfred Spraul <manfred@colorfullife.com>");
MODULE_DESCRIPTION("Reverse Engineered nForce ethernet driver");
MODULE_LICENSE("GPL");
-
MODULE_DEVICE_TABLE(pci, pci_tbl);
-
-module_init(init_nic);
-module_exit(exit_nic);
--
1.8.1.5
next prev parent reply other threads:[~2013-05-21 23:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 22:42 [PATCH 01/19] net/ethernet/silan/sc92031: " Peter Huewe
2013-05-21 22:42 ` [PATCH 02/19] net/ethernet/atheros/atl1c/atl1c_main: " Peter Huewe
2013-05-21 22:42 ` [PATCH 03/19] net/ethernet/atheros/atl1e/atl1e_main: " Peter Huewe
2013-05-22 0:19 ` Hannes Frederic Sowa
2013-05-21 22:42 ` [PATCH 04/19] net/ethernet/atheros/atlx/atl1: " Peter Huewe
2013-05-21 22:42 ` [PATCH 05/19] net/ethernet/sis/sis190: " Peter Huewe
2013-05-21 22:42 ` [PATCH 06/19] net/ethernet/dec/tulip/xircom_cb: " Peter Huewe
2013-05-22 0:41 ` Grant Grundler
2013-05-21 22:42 ` [PATCH 07/19] net/ethernet/toshiba/tc35815: " Peter Huewe
2013-05-21 22:42 ` [PATCH 08/19] net/ethernet/icplus/ipg: " Peter Huewe
2013-05-21 22:42 ` [PATCH 09/19] net/ethernet/alteon/acenic: " Peter Huewe
2013-05-21 22:58 ` [PATCH 10/19] net/ethernet/broadcom/bnx2: " Peter Huewe
2013-05-21 22:58 ` [PATCH 11/19] net/ethernet/broadcom/tg3: " Peter Huewe
2013-05-22 0:22 ` Nithin Nayak Sujir
2013-05-21 22:58 ` [PATCH 12/19] net/ethernet/sgi/ioc3-eth: " Peter Huewe
2013-05-22 7:53 ` Ralf Baechle
2013-05-21 22:58 ` [PATCH 13/19] net/ethernet/qlogic/qlge/qlge_main: " Peter Huewe
2013-05-21 22:58 ` [PATCH 14/19] net/ethernet/sun/sungem: " Peter Huewe
2013-05-21 22:58 ` [PATCH 15/19] net/ethernet/amd/amd8111e: " Peter Huewe
2013-05-21 23:42 ` [PATCH 16/19] net/hippi/rrunner: " Peter Huewe
2013-05-21 23:42 ` [PATCH 17/19] net/fddi/skfp/skfddi: " Peter Huewe
2013-05-21 23:42 ` [PATCH 18/19] net/ethernet/chelsio/cxgb/cxgb2: " Peter Huewe
2013-05-21 23:42 ` Peter Huewe [this message]
2013-05-22 21:44 ` [PATCH 01/19] net/ethernet/silan/sc92031: " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369179778-20115-19-git-send-email-peterhuewe@gmx.de \
--to=peterhuewe@gmx.de \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=decot@googlers.com \
--cc=jiri@resnulli.us \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®