From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
David Ahern <dsahern@gmail.com>,
Stephane Eranian <eranian@google.com>,
Pekka Enberg <penberg@kernel.org>
Subject: [PATCH 2/5] perf gtk/hists: Add support for callchains
Date: Wed, 22 May 2013 17:27:35 +0900 [thread overview]
Message-ID: <1369211258-3163-3-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1369211258-3163-1-git-send-email-namhyung@kernel.org>
From: Namhyung Kim <namhyung.kim@lge.com>
Add a new column to display callchain information. It's only enabled
when recorded with -g and has symbol sort key.
Cc: Pekka Enberg <penberg@kernel.org>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/ui/gtk/hists.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 60 insertions(+)
diff --git a/tools/perf/ui/gtk/hists.c b/tools/perf/ui/gtk/hists.c
index cb6a9b45f789..14d0b26c7c8a 100644
--- a/tools/perf/ui/gtk/hists.c
+++ b/tools/perf/ui/gtk/hists.c
@@ -124,6 +124,41 @@ void perf_gtk__init_hpp(void)
perf_gtk__hpp_color_overhead_guest_us;
}
+static void callchain_list__sym_name(struct callchain_list *cl,
+ char *bf, size_t bfsize)
+{
+ if (cl->ms.sym)
+ scnprintf(bf, bfsize, "%s", cl->ms.sym->name);
+ else
+ scnprintf(bf, bfsize, "%#" PRIx64, cl->ip);
+}
+
+static void perf_gtk__add_callchain(struct rb_root *root, GtkTreeStore *store,
+ GtkTreeIter *parent, int col)
+{
+ struct rb_node *nd;
+
+ for (nd = rb_first(root); nd; nd = rb_next(nd)) {
+ struct callchain_node *node;
+ struct callchain_list *chain;
+ GtkTreeIter iter;
+
+ node = rb_entry(nd, struct callchain_node, rb_node);
+
+ list_for_each_entry(chain, &node->val, list) {
+ char buf[128];
+
+ gtk_tree_store_append(store, &iter, parent);
+
+ callchain_list__sym_name(chain, buf, sizeof(buf));
+ gtk_tree_store_set(store, &iter, col, buf, -1);
+ }
+
+ /* Now 'iter' contains info of the last callchain_list */
+ perf_gtk__add_callchain(&node->rb_root, store, &iter, col);
+ }
+}
+
static void perf_gtk__show_hists(GtkWidget *window, struct hists *hists,
float min_pcnt)
{
@@ -156,6 +191,9 @@ static void perf_gtk__show_hists(GtkWidget *window, struct hists *hists,
col_types[nr_cols++] = G_TYPE_STRING;
}
+ if (symbol_conf.use_callchain && sort__has_sym)
+ col_types[nr_cols++] = G_TYPE_STRING;
+
store = gtk_tree_store_newv(nr_cols, col_types);
view = gtk_tree_view_new();
@@ -183,6 +221,23 @@ static void perf_gtk__show_hists(GtkWidget *window, struct hists *hists,
col_idx++, NULL);
}
+ if (symbol_conf.use_callchain && sort__has_sym) {
+ GtkTreeViewColumn *chain_column;
+
+ chain_column = gtk_tree_view_column_new();
+
+ gtk_tree_view_column_set_title(chain_column, "Callchains");
+ gtk_tree_view_column_pack_start(chain_column, renderer, TRUE);
+ gtk_tree_view_column_add_attribute(chain_column, renderer,
+ "text", col_idx++);
+
+ gtk_tree_view_insert_column(GTK_TREE_VIEW(view),
+ chain_column, -1);
+
+ gtk_tree_view_set_expander_column(GTK_TREE_VIEW(view),
+ chain_column);
+ }
+
gtk_tree_view_set_model(GTK_TREE_VIEW(view), GTK_TREE_MODEL(store));
g_object_unref(GTK_TREE_MODEL(store));
@@ -221,6 +276,11 @@ static void perf_gtk__show_hists(GtkWidget *window, struct hists *hists,
gtk_tree_store_set(store, &iter, col_idx++, s, -1);
}
+
+ if (symbol_conf.use_callchain && sort__has_sym) {
+ gtk_tree_store_set(store, &iter, col_idx, "callchain", -1);
+ perf_gtk__add_callchain(&h->sorted_chain, store, &iter, col_idx);
+ }
}
gtk_container_add(GTK_CONTAINER(window), view);
--
1.7.11.7
next prev parent reply other threads:[~2013-05-22 8:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 8:27 [PATCH 0/5] perf report: Add support for callchains on GTK browser Namhyung Kim
2013-05-22 8:27 ` [PATCH 1/5] perf gtk/hists: Use GtkTreeStore instead of GtkListStore Namhyung Kim
2013-05-22 8:37 ` Pekka Enberg
2013-05-22 8:27 ` Namhyung Kim [this message]
2013-05-22 8:38 ` [PATCH 2/5] perf gtk/hists: Add support for callchains Pekka Enberg
2013-05-22 8:27 ` [PATCH 3/5] perf gtk/hists: Display callchain overhead also Namhyung Kim
2013-05-22 8:39 ` Pekka Enberg
2013-05-22 9:52 ` Arnaldo Carvalho de Melo
2013-05-23 2:37 ` Namhyung Kim
2013-05-28 8:48 ` Ingo Molnar
2013-06-02 2:50 ` Namhyung Kim
2013-05-22 8:27 ` [PATCH 4/5] perf gtk/hists: Add a double-click handler for callchains Namhyung Kim
2013-05-22 8:39 ` Pekka Enberg
2013-05-22 8:27 ` [PATCH 5/5] perf gtk/hists: Make column headers resizable Namhyung Kim
2013-05-22 8:37 ` [PATCH v2 " Namhyung Kim
2013-05-22 8:39 ` Pekka Enberg
2013-05-22 8:40 ` [PATCH 0/5] perf report: Add support for callchains on GTK browser Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369211258-3163-3-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®