From: <yizhang.mrvl@gmail.com>
To: <sameo@linux.intel.com>, <gregkh@linuxfoundation.org>,
<yizhang.mrvl@gmail.com>
Cc: <cxie4@marvell.com>, <arnd@arndb.de>, <yizhang@marvell.com>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH 1/4] mfd: 88pm800: fix NULL pointer error
Date: Wed, 22 May 2013 20:07:06 +0800 [thread overview]
Message-ID: <1369224429-27077-2-git-send-email-yizhang.mrvl@gmail.com> (raw)
In-Reply-To: <1369224429-27077-1-git-send-email-yizhang.mrvl@gmail.com>
From: Yi Zhang <yizhang@marvell.com>
move "device_800_init" to fix NULL pointer error when
calling "device_gpadc_init"
for "device_gpadc_init" needs "subchip->regmap_gpadc"
to set registers via regmap interface
Signed-off-by: Yi Zhang <yizhang@marvell.com>
---
drivers/mfd/88pm800.c | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c
index 582bda5..bbb6aa8 100644
--- a/drivers/mfd/88pm800.c
+++ b/drivers/mfd/88pm800.c
@@ -528,25 +528,25 @@ static int pm800_probe(struct i2c_client *client,
subchip->gpadc_page_addr = pdata->gpadc_page_addr;
chip->subchip = subchip;
- ret = device_800_init(chip, pdata);
- if (ret) {
- dev_err(chip->dev, "%s id 0x%x failed!\n", __func__, chip->id);
- goto err_subchip_alloc;
- }
-
ret = pm800_pages_init(chip);
if (ret) {
dev_err(&client->dev, "pm800_pages_init failed!\n");
goto err_page_init;
}
+ ret = device_800_init(chip, pdata);
+ if (ret) {
+ dev_err(chip->dev, "%s id 0x%x failed!\n", __func__, chip->id);
+ goto err_subchip_alloc;
+ }
+
if (pdata->plat_config)
pdata->plat_config(chip, pdata);
-err_page_init:
+err_subchip_alloc:
mfd_remove_devices(chip->dev);
device_irq_exit_800(chip);
-err_subchip_alloc:
+err_page_init:
pm80x_deinit();
out_init:
return ret;
--
1.7.0.4
next prev parent reply other threads:[~2013-05-22 12:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 12:07 [PATCH 0/3] *** SUBJECT HERE *** yizhang.mrvl
2013-05-22 12:07 ` yizhang.mrvl [this message]
2013-05-22 12:07 ` [PATCH 2/4] mfd: 88pm800: remove "IRQF_TRIGGER_FALLING" flag yizhang.mrvl
2013-05-22 12:07 ` [PATCH 3/4] mfd: 88pm800: fix probe bug yizhang.mrvl
2013-05-22 12:07 ` [PATCH 4/4] mfd: 88pm800: add regulator support yizhang.mrvl
2013-05-22 14:06 ` [PATCH 0/3] *** SUBJECT HERE *** Greg KH
2013-05-23 11:04 ` yi zhang
2013-05-23 11:10 [PATCH 0/3] mfd: 88pm800: bug fix and add regulator support yizhang.mrvl
2013-05-23 11:10 ` [PATCH 1/4] mfd: 88pm800: fix NULL pointer error yizhang.mrvl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369224429-27077-2-git-send-email-yizhang.mrvl@gmail.com \
--to=yizhang.mrvl@gmail.com \
--cc=arnd@arndb.de \
--cc=cxie4@marvell.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=yizhang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®