From: Wolfram Sang <wsa@the-dreams.de>
To: linux-kernel@vger.kernel.org
Cc: Wolfram Sang <wsa@the-dreams.de>,
Deepak Saxena <dsaxena@plexity.net>,
Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.hengli.com.au>
Subject: [PATCH 1/3] drivers/char/hw_random: remove leftover release_mem_region
Date: Wed, 22 May 2013 15:21:24 +0200 [thread overview]
Message-ID: <1369228886-3527-1-git-send-email-wsa@the-dreams.de> (raw)
When converting this driver to devm_ioremap_resource, the removal of this now
unneeded function has been forgotten.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/char/hw_random/omap-rng.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/char/hw_random/omap-rng.c b/drivers/char/hw_random/omap-rng.c
index d2903e7..7af2b24 100644
--- a/drivers/char/hw_random/omap-rng.c
+++ b/drivers/char/hw_random/omap-rng.c
@@ -52,7 +52,6 @@
*/
struct omap_rng_private_data {
void __iomem *base;
- struct resource *mem_res;
};
static inline u32 omap_rng_read_reg(struct omap_rng_private_data *priv, int reg)
@@ -107,6 +106,7 @@ static struct hwrng omap_rng_ops = {
static int omap_rng_probe(struct platform_device *pdev)
{
struct omap_rng_private_data *priv;
+ struct resource *mem_res;
int ret;
priv = kzalloc(sizeof(struct omap_rng_private_data), GFP_KERNEL);
@@ -118,8 +118,8 @@ static int omap_rng_probe(struct platform_device *pdev)
omap_rng_ops.priv = (unsigned long)priv;
dev_set_drvdata(&pdev->dev, priv);
- priv->mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- priv->base = devm_ioremap_resource(&pdev->dev, priv->mem_res);
+ mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ priv->base = devm_ioremap_resource(&pdev->dev, mem_res);
if (IS_ERR(priv->base)) {
ret = PTR_ERR(priv->base);
goto err_ioremap;
@@ -160,8 +160,6 @@ static int __exit omap_rng_remove(struct platform_device *pdev)
pm_runtime_put_sync(&pdev->dev);
pm_runtime_disable(&pdev->dev);
- release_mem_region(priv->mem_res->start, resource_size(priv->mem_res));
-
kfree(priv);
return 0;
--
1.7.10.4
next reply other threads:[~2013-05-22 13:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 13:21 Wolfram Sang [this message]
2013-05-22 13:21 ` [PATCH 2/3] drivers/usb/host: " Wolfram Sang
2013-05-22 14:21 ` Alan Stern
2013-05-22 13:21 ` [PATCH 3/3] sound/soc/fsl: " Wolfram Sang
2013-05-22 15:56 ` Mark Brown
2013-05-22 16:04 ` Wolfram Sang
2013-05-22 16:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369228886-3527-1-git-send-email-wsa@the-dreams.de \
--to=wsa@the-dreams.de \
--cc=dsaxena@plexity.net \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®