From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754805Ab3EVOPJ (ORCPT ); Wed, 22 May 2013 10:15:09 -0400 Received: from arkanian.console-pimps.org ([212.110.184.194]:37093 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750921Ab3EVOPH (ORCPT ); Wed, 22 May 2013 10:15:07 -0400 From: Matt Fleming To: linux-efi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Matt Fleming Subject: [PATCH] x86, efi: retry ExitBootServices() on failure Date: Wed, 22 May 2013 15:15:00 +0100 Message-Id: <1369232100-27232-1-git-send-email-matt@console-pimps.org> X-Mailer: git-send-email 1.8.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matt Fleming ExitBootServices() can legitimately fail if any of the event handlers that are signaled by its invocation change the memory map. In that case, we need to get the memory map and exit boot services again. Only retry once so that we don't get stuck if ExitBootServices() is returning a genuine error value. Signed-off-by: Matt Fleming --- arch/x86/boot/compressed/eboot.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c index 35ee62f..a88a81d 100644 --- a/arch/x86/boot/compressed/eboot.c +++ b/arch/x86/boot/compressed/eboot.c @@ -1037,6 +1037,7 @@ static efi_status_t exit_boot(struct boot_params *boot_params, efi_memory_desc_t *mem_map; efi_status_t status; __u32 desc_version; + bool called_exit = false; u8 nr_entries; int i; @@ -1049,9 +1050,10 @@ again: if (status != EFI_SUCCESS) return status; +get_map: status = efi_call_phys5(sys_table->boottime->get_memory_map, &size, mem_map, &key, &desc_size, &desc_version); - if (status == EFI_BUFFER_TOO_SMALL) { + if (status == EFI_BUFFER_TOO_SMALL && !called_exit) { low_free(_size, (unsigned long)mem_map); goto again; } @@ -1074,8 +1076,20 @@ again: /* Might as well exit boot services now */ status = efi_call_phys2(sys_table->boottime->exit_boot_services, handle, key); - if (status != EFI_SUCCESS) - goto free_mem_map; + if (status != EFI_SUCCESS) { + /* + * ExitBootServices() will fail if any of the event + * handlers change the memory map. In which case, we + * must be prepared to retry, but only once so that + * we're guaranteed to exit on repeated failures instead + * of spinning forever. + */ + if (called_exit) + goto free_mem_map; + + called_exit = true; + goto get_map; + } /* Historic? */ boot_params->alt_mem_k = 32 * 1024; -- 1.8.1.4