From: Ravi Babu <ravibabu@ti.com>
To: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <balbi@ti.com>, Ravi Babu <ravibabu@ti.com>
Subject: [PATCH v1 4/9] usb: phy: nop: removing unused usb_nop_xceiv_(un_)register API
Date: Thu, 23 May 2013 11:31:23 +0530 [thread overview]
Message-ID: <1369288888-8614-5-git-send-email-ravibabu@ti.com> (raw)
In-Reply-To: <1369288888-8614-1-git-send-email-ravibabu@ti.com>
remove the unused the usb_nop_xceiv_register & _unregister API's
from phy-nop driver. The glue platform driver should use DT bindings
use usb-nop-xceiv driver
Signed-off-by: Ravi Babu <ravibabu@ti.com>
---
drivers/usb/musb/musb_dsps.c | 1 -
drivers/usb/phy/phy-nop.c | 21 ---------------------
include/linux/usb/nop-usb-xceiv.h | 14 --------------
3 files changed, 0 insertions(+), 36 deletions(-)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index 14067a1..0ecedb3 100644
--- a/drivers/usb/musb/musb_dsps.c
+++ b/drivers/usb/musb/musb_dsps.c
@@ -36,7 +36,6 @@
#include <linux/dma-mapping.h>
#include <linux/pm_runtime.h>
#include <linux/module.h>
-#include <linux/usb/nop-usb-xceiv.h>
#include <linux/platform_data/usb-omap.h>
#include <linux/sizes.h>
diff --git a/drivers/usb/phy/phy-nop.c b/drivers/usb/phy/phy-nop.c
index 2b10cc9..52d3fdd 100644
--- a/drivers/usb/phy/phy-nop.c
+++ b/drivers/usb/phy/phy-nop.c
@@ -44,27 +44,6 @@ struct nop_usb_xceiv {
struct regulator *reset;
};
-static struct platform_device *pd;
-
-void usb_nop_xceiv_register(void)
-{
- if (pd)
- return;
- pd = platform_device_register_simple("nop_usb_xceiv", -1, NULL, 0);
- if (!pd) {
- printk(KERN_ERR "Unable to register usb nop transceiver\n");
- return;
- }
-}
-EXPORT_SYMBOL(usb_nop_xceiv_register);
-
-void usb_nop_xceiv_unregister(void)
-{
- platform_device_unregister(pd);
- pd = NULL;
-}
-EXPORT_SYMBOL(usb_nop_xceiv_unregister);
-
static int nop_set_suspend(struct usb_phy *x, int suspend)
{
return 0;
diff --git a/include/linux/usb/nop-usb-xceiv.h b/include/linux/usb/nop-usb-xceiv.h
index 148d351..b23c942 100644
--- a/include/linux/usb/nop-usb-xceiv.h
+++ b/include/linux/usb/nop-usb-xceiv.h
@@ -12,18 +12,4 @@ struct nop_usb_xceiv_platform_data {
unsigned int needs_reset:1;
};
-#if defined(CONFIG_NOP_USB_XCEIV) || (defined(CONFIG_NOP_USB_XCEIV_MODULE) && defined(MODULE))
-/* sometimes transceivers are accessed only through e.g. ULPI */
-extern void usb_nop_xceiv_register(void);
-extern void usb_nop_xceiv_unregister(void);
-#else
-static inline void usb_nop_xceiv_register(void)
-{
-}
-
-static inline void usb_nop_xceiv_unregister(void)
-{
-}
-#endif
-
#endif /* __LINUX_USB_NOP_XCEIV_H */
--
1.7.0.4
next prev parent reply other threads:[~2013-05-23 6:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 6:01 [PATCH v1 0/9] adding dual instance and usb-phy support for am335x platform Ravi Babu
2013-05-23 6:01 ` [PATCH v1 1/9] usb: musb: dsps: enable dual instance support for am33xx platform Ravi Babu
2013-05-23 6:01 ` [PATCH v1 2/9] usb: musb: nop: remove unused nop_xceiv_(un)register APIs from glue Ravi Babu
2013-05-23 14:22 ` Sergei Shtylyov
2013-05-23 17:07 ` B, Ravi
2013-05-23 18:21 ` Sergei Shtylyov
2013-05-24 5:34 ` B, Ravi
2013-05-24 14:41 ` Sergei Shtylyov
2013-05-23 6:01 ` [PATCH v1 3/9] arch: arm: omap3: remove unused usb_nop_xceive register API's Ravi Babu
2013-05-23 6:01 ` Ravi Babu [this message]
2013-05-23 6:01 ` [PATCH v1 5/9] usb: phy: dsps: adding usbphy driver for am33xx platform Ravi Babu
2013-05-23 6:01 ` [PATCH v1 6/9] usb: musb: dsps: use usb-phy driver API for phy power on/off Ravi Babu
2013-05-23 6:01 ` [PATCH v1 7/9] usb: musb: dsps: use get-usb-phy by phandle for multi instance Ravi Babu
2013-05-23 14:25 ` Sergei Shtylyov
2013-05-23 17:09 ` B, Ravi
2013-05-23 6:01 ` [PATCH v1 8/9] usb: phy: dts: Adding usbphy DT bindings for am33xx Ravi Babu
2013-05-23 14:27 ` Sergei Shtylyov
2013-05-23 17:13 ` B, Ravi
2013-05-23 18:18 ` Sergei Shtylyov
2013-05-24 5:34 ` B, Ravi
2013-06-01 14:39 ` Sergei Shtylyov
2013-05-23 6:01 ` [PATCH v1 9/9] usb: musb: dsp: remove the usb-phy control acess from platform glue Ravi Babu
2013-05-28 17:39 ` [PATCH v1 0/9] adding dual instance and usb-phy support for am335x platform Felipe Balbi
2013-05-29 3:46 ` B, Ravi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369288888-8614-5-git-send-email-ravibabu@ti.com \
--to=ravibabu@ti.com \
--cc=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®