From: <yizhang.mrvl@gmail.com>
To: <sameo@linux.intel.com>, <gregkh@linuxfoundation.org>,
<yizhang.mrvl@gmail.com>
Cc: <cxie4@marvell.com>, <arnd@arndb.de>, <yizhang@marvell.com>,
<linux-kernel@vger.kernel.org>, <jtzhou@marvell.com>
Subject: [PATCH 2/4] mfd: 88pm800: remove "IRQF_TRIGGER_FALLING" flag
Date: Thu, 23 May 2013 19:10:45 +0800 [thread overview]
Message-ID: <1369307447-17874-3-git-send-email-yizhang.mrvl@gmail.com> (raw)
In-Reply-To: <1369307447-17874-1-git-send-email-yizhang.mrvl@gmail.com>
From: Yi Zhang <yizhang@marvell.com>
for interrupt controller such as GIC who is level triggered,
"IRQF_TRIGGER_FALLING" will fail to request irq
Signed-off-by: Yi Zhang <yizhang@marvell.com>
---
drivers/mfd/88pm800.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c
index bbb6aa8..618a6b9 100644
--- a/drivers/mfd/88pm800.c
+++ b/drivers/mfd/88pm800.c
@@ -318,7 +318,7 @@ out:
static int device_irq_init_800(struct pm80x_chip *chip)
{
struct regmap *map = chip->regmap;
- unsigned long flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT;
+ unsigned long flags = IRQF_ONESHOT;
int data, mask, ret = -EINVAL;
if (!map || !chip->irq) {
--
1.7.0.4
next prev parent reply other threads:[~2013-05-23 11:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 11:10 [PATCH 0/3] mfd: 88pm800: bug fix and add regulator support yizhang.mrvl
2013-05-23 11:10 ` [PATCH 1/4] mfd: 88pm800: fix NULL pointer error yizhang.mrvl
2013-05-23 11:10 ` yizhang.mrvl [this message]
2013-05-23 11:10 ` [PATCH 3/4] mfd: 88pm800: fix probe bug yizhang.mrvl
2013-05-23 11:10 ` [PATCH 4/4] mfd: 88pm800: add regulator support yizhang.mrvl
-- strict thread matches above, loose matches on Subject: below --
2013-05-22 12:07 [PATCH 0/3] *** SUBJECT HERE *** yizhang.mrvl
2013-05-22 12:07 ` [PATCH 2/4] mfd: 88pm800: remove "IRQF_TRIGGER_FALLING" flag yizhang.mrvl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369307447-17874-3-git-send-email-yizhang.mrvl@gmail.com \
--to=yizhang.mrvl@gmail.com \
--cc=arnd@arndb.de \
--cc=cxie4@marvell.com \
--cc=gregkh@linuxfoundation.org \
--cc=jtzhou@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=yizhang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®