From: Joe Perches <joe@perches.com>
To: Lisa Nguyen <lisa@xenapiadmin.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] staging/silicom/bypasslib: Reformat comments
Date: Thu, 23 May 2013 15:42:54 -0700 [thread overview]
Message-ID: <1369348974.2075.52.camel@joe-AO722> (raw)
In-Reply-To: <8f0a1b9dd2524047034345709cb11102ca44eded.1369342182.git.lisa@xenapiadmin.com>
On Thu, 2013-05-23 at 13:51 -0700, Lisa Nguyen wrote:
> Resolved the C99 comment style issue by reformatting existing comments
> to meet kernel coding standards in bp_ioctl.h
[]
> diff --git a/drivers/staging/silicom/bypasslib/bp_ioctl.h b/drivers/staging/silicom/bypasslib/bp_ioctl.h
[]
> -#define BP_CAP 0x01 //BIT_0
[...]
> +#define BP_CAP 0x01 /* BIT_0 */
Better to use the more self-documenting
#define BP_CAP BIT(0)
etc... with out any comment at all.
prev parent reply other threads:[~2013-05-23 22:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 20:51 Lisa Nguyen
2013-05-23 20:52 ` [PATCH 2/7] staging/silicom/bypasslib: Fix code indentation errors Lisa Nguyen
2013-05-23 20:52 ` [PATCH 3/7] staging/silicom/bypasslib: Add space around == Lisa Nguyen
2013-05-23 20:53 ` [PATCH 4/7] staging/silicom/bypasslib: Add space around && Lisa Nguyen
2013-05-23 20:53 ` [PATCH 5/7] staging/silicom/bypasslib: Add space around || Lisa Nguyen
2013-05-23 20:54 ` [PATCH 6/7] staging/silicom/bypasslib: Remove extra space before line Lisa Nguyen
2013-05-23 20:54 ` [PATCH 7/7] staging/silicom/bypasslib: Move opening brace to previous line Lisa Nguyen
2013-05-23 22:42 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369348974.2075.52.camel@joe-AO722 \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lisa@xenapiadmin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®