mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-kernel@vger.kernel.org, Vinod Koul <vinod.koul@intel.com>,
	Dan Williams <djbw@fb.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH 04/12] ep93xx_dma: remove useless use of lock
Date: Mon, 27 May 2013 15:14:34 +0300	[thread overview]
Message-ID: <1369656882-25241-5-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <1369656882-25241-1-git-send-email-andriy.shevchenko@linux.intel.com>

Accordingly to dma_cookie_status() description locking is not required.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/dma/ep93xx_dma.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
index f2bf8c0..591cd8c 100644
--- a/drivers/dma/ep93xx_dma.c
+++ b/drivers/dma/ep93xx_dma.c
@@ -1313,15 +1313,7 @@ static enum dma_status ep93xx_dma_tx_status(struct dma_chan *chan,
 					    dma_cookie_t cookie,
 					    struct dma_tx_state *state)
 {
-	struct ep93xx_dma_chan *edmac = to_ep93xx_dma_chan(chan);
-	enum dma_status ret;
-	unsigned long flags;
-
-	spin_lock_irqsave(&edmac->lock, flags);
-	ret = dma_cookie_status(chan, cookie, state);
-	spin_unlock_irqrestore(&edmac->lock, flags);
-
-	return ret;
+	return dma_cookie_status(chan, cookie, state);
 }
 
 /**
-- 
1.8.2.rc0.22.gb3600c3


  parent reply	other threads:[~2013-05-27 12:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-27 12:14 [PATCH 00/12] dma: various minor clean ups for slave drivers Andy Shevchenko
2013-05-27 12:14 ` [PATCH 01/12] imx-sdma: remove useless variable Andy Shevchenko
2013-05-27 12:14 ` [PATCH 02/12] mxs-dma: " Andy Shevchenko
2013-05-27 12:14 ` [PATCH 03/12] edma: no need to assign residue to 0 explicitly Andy Shevchenko
2013-05-27 12:14 ` Andy Shevchenko [this message]
2013-05-27 12:14 ` [PATCH 05/12] fsldma: remove useless use of lock Andy Shevchenko
2013-05-27 12:14 ` [PATCH 06/12] mmp_pdma: " Andy Shevchenko
2013-05-27 12:14 ` [PATCH 07/12] mpc512x_dma: " Andy Shevchenko
2013-05-27 12:14 ` [PATCH 08/12] pch_dma: " Andy Shevchenko
2013-05-27 12:14 ` [PATCH 09/12] tegra20-apb-dma: " Andy Shevchenko
2013-05-29 10:56   ` Laxman Dewangan
2013-05-29 13:42     ` Andy Shevchenko
2013-05-27 12:14 ` [PATCH 10/12] ipu_idmac: re-use dma_cookie_status() Andy Shevchenko
2013-05-29  2:19   ` Shawn Guo
2013-05-27 12:14 ` [PATCH 11/12] mmp_tdma: set cookies as well when asked for tx status Andy Shevchenko
2013-05-27 12:14 ` [PATCH 12/12] txx9dmac: return DMA_SUCCESS immediately from device_tx_status() Andy Shevchenko
2013-05-30 17:47 ` [PATCH 00/12] dma: various minor clean ups for slave drivers Vinod Koul
2013-05-30 18:32   ` Andy Shevchenko
2013-07-15  9:37     ` Vinod Koul
2013-07-15 10:21       ` Andy Shevchenko
2013-07-15  9:59         ` Vinod Koul
2013-06-01  0:09   ` Dan Williams
2013-07-15  9:33     ` Vinod Koul
2013-07-10  7:54   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369656882-25241-5-git-send-email-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=djbw@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome