From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933645Ab3E1ItX (ORCPT ); Tue, 28 May 2013 04:49:23 -0400 Received: from mga14.intel.com ([143.182.124.37]:20442 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933619Ab3E1ItW convert rfc822-to-8bit (ORCPT ); Tue, 28 May 2013 04:49:22 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,756,1363158000"; d="scan'208";a="341207824" Message-ID: <1369730942.29283.223.camel@smile> Subject: Re: [PATCH] pch_phub: re-use native MAC address parser From: Andy Shevchenko To: linux-kernel@vger.kernel.org Cc: Arnd Bergmann , Greg Kroah-Hartman Date: Tue, 28 May 2013 11:49:02 +0300 In-Reply-To: <1366723890-23838-1-git-send-email-andriy.shevchenko@linux.intel.com> References: <1366723890-23838-1-git-send-email-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.4.4-3 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2013-04-23 at 16:31 +0300, Andy Shevchenko wrote: > We have mac_pton() helper to parse MAC addresses. > > Signed-off-by: Andy Shevchenko > --- > drivers/misc/pch_phub.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/misc/pch_phub.c b/drivers/misc/pch_phub.c > index 931e635..8b4d4fb 100644 > --- a/drivers/misc/pch_phub.c > +++ b/drivers/misc/pch_phub.c > @@ -633,17 +633,13 @@ static ssize_t show_pch_mac(struct device *dev, struct device_attribute *attr, > static ssize_t store_pch_mac(struct device *dev, struct device_attribute *attr, > const char *buf, size_t count) > { > - u8 mac[6]; > + u8 mac[ETH_ALEN]; > ssize_t rom_size; > struct pch_phub_reg *chip = dev_get_drvdata(dev); > > - if (count != 18) > + if (!mac_pton(buf, mac)) > return -EINVAL; > > - sscanf(buf, "%02x:%02x:%02x:%02x:%02x:%02x", > - (u32 *)&mac[0], (u32 *)&mac[1], (u32 *)&mac[2], (u32 *)&mac[3], > - (u32 *)&mac[4], (u32 *)&mac[5]); > - > chip->pch_phub_extrom_base_address = pci_map_rom(chip->pdev, &rom_size); > if (!chip->pch_phub_extrom_base_address) > return -ENOMEM; Arnd, do you have any comment on this one? -- Andy Shevchenko Intel Finland Oy