From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ingo Molnar <mingo@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 9p: trace: use %*ph to dump buffer
Date: Tue, 28 May 2013 11:49:52 +0300 [thread overview]
Message-ID: <1369730992.29283.224.camel@smile> (raw)
In-Reply-To: <1366635713-11435-1-git-send-email-andriy.shevchenko@linux.intel.com>
On Mon, 2013-04-22 at 16:01 +0300, Andy Shevchenko wrote:
> Additionally change cast from long to unsigned long to follow specificator.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/trace/events/9p.h | 28 +++-------------------------
> 1 file changed, 3 insertions(+), 25 deletions(-)
>
> diff --git a/include/trace/events/9p.h b/include/trace/events/9p.h
> index beeaed8..a066636 100644
> --- a/include/trace/events/9p.h
> +++ b/include/trace/events/9p.h
> @@ -143,31 +143,9 @@ TRACE_EVENT(9p_protocol_dump,
> __entry->tag = pdu->tag;
> memcpy(__entry->line, pdu->sdata, P9_PROTO_DUMP_SZ);
> ),
> - TP_printk("clnt %lu %s(tag = %d)\n%.3x: "
> - "%02x %02x %02x %02x %02x %02x %02x %02x "
> - "%02x %02x %02x %02x %02x %02x %02x %02x\n"
> - "%.3x: "
> - "%02x %02x %02x %02x %02x %02x %02x %02x "
> - "%02x %02x %02x %02x %02x %02x %02x %02x\n",
> - (long)__entry->clnt, show_9p_op(__entry->type),
> - __entry->tag, 0,
> - __entry->line[0], __entry->line[1],
> - __entry->line[2], __entry->line[3],
> - __entry->line[4], __entry->line[5],
> - __entry->line[6], __entry->line[7],
> - __entry->line[8], __entry->line[9],
> - __entry->line[10], __entry->line[11],
> - __entry->line[12], __entry->line[13],
> - __entry->line[14], __entry->line[15],
> - 16,
> - __entry->line[16], __entry->line[17],
> - __entry->line[18], __entry->line[19],
> - __entry->line[20], __entry->line[21],
> - __entry->line[22], __entry->line[23],
> - __entry->line[24], __entry->line[25],
> - __entry->line[26], __entry->line[27],
> - __entry->line[28], __entry->line[29],
> - __entry->line[30], __entry->line[31])
> + TP_printk("clnt %lu %s(tag = %d)\n%.3x: %16ph\n%.3x: %16ph\n",
> + (unsigned long)__entry->clnt, show_9p_op(__entry->type),
> + __entry->tag, 0, __entry->line, 16, __entry->line + 16)
> );
>
> #endif /* _TRACE_9P_H */
Any comment on this one, anyone?
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2013-05-28 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 13:01 Andy Shevchenko
2013-05-28 8:49 ` Andy Shevchenko [this message]
2013-05-28 18:09 ` Rob Landley
2013-05-28 18:45 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369730992.29283.224.camel@smile \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome