From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3619CC678D6 for ; Fri, 20 Jan 2023 05:23:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231408AbjATFXi (ORCPT ); Fri, 20 Jan 2023 00:23:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231347AbjATFXO (ORCPT ); Fri, 20 Jan 2023 00:23:14 -0500 Received: from mx.socionext.com (mx.socionext.com [202.248.49.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BE6B7518FD; Thu, 19 Jan 2023 21:13:19 -0800 (PST) Received: from unknown (HELO kinkan2-ex.css.socionext.com) ([172.31.9.52]) by mx.socionext.com with ESMTP; 20 Jan 2023 13:54:07 +0900 Received: from mail.mfilter.local (m-filter-1 [10.213.24.61]) by kinkan2-ex.css.socionext.com (Postfix) with ESMTP id E2C412059054; Fri, 20 Jan 2023 13:54:07 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Fri, 20 Jan 2023 13:54:08 +0900 Received: from [10.212.158.61] (unknown [10.212.158.61]) by kinkan2.css.socionext.com (Postfix) with ESMTP id 4FE257BCC; Fri, 20 Jan 2023 13:54:07 +0900 (JST) Message-ID: <13697e8c-977d-aad3-18d6-e520fc1013f8@socionext.com> Date: Fri, 20 Jan 2023 13:54:07 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] dt-bindings: soc: socionext,uniphier-soc-glue: Make child node names fixed names To: Rob Herring , Krzysztof Kozlowski , Masami Hiramatsu Cc: Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230120020339.3223112-1-robh@kernel.org> Content-Language: en-US From: Kunihiko Hayashi In-Reply-To: <20230120020339.3223112-1-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On 2023/01/20 11:03, Rob Herring wrote: > The child nodes 'pinctrl', 'usb-hub', and 'clock-controller' in the > socionext,uniphier-soc-glue binding are not patterns, but the full node > name, so move them to 'properties'. As patterns, they were missing start > and end anchors so any prefix or suffix was allowed. > > Fixes: 0611adff8b3a ("dt-bindings: soc: socionext: Add UniPhier SoC-glue > logic") > Signed-off-by: Rob Herring > --- > .../bindings/soc/socionext/socionext,uniphier-soc-glue.yaml | 1 - > 1 file changed, 1 deletion(-) > > diff --git > a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g > lue.yaml > b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g > lue.yaml > index 4b6852db4747..7845dcfca986 100644 > --- > a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g > lue.yaml > +++ > b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g > lue.yaml > @@ -32,7 +32,6 @@ properties: > reg: > maxItems: 1 > > -patternProperties: > pinctrl: > $ref: /schemas/pinctrl/socionext,uniphier-pinctrl.yaml# > Thanks for pointing out. This is because I forgot to remove it when I changed the child node, and it should be removed. Reviewed-by: Kunihiko Hayashi Thank you, --- Best Regards Kunihiko Hayashi