mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@ti.com>
To: Tony Lindgren <tony@atomide.com>, Wolfram Sang <wsa@the-dreams.de>
Cc: <linux-omap@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH 0/1] i2c: omap: correct usage of the interrupt enable register
Date: Wed, 29 May 2013 10:35:43 +0300	[thread overview]
Message-ID: <1369812944-685-1-git-send-email-oleksandr.dmytryshyn@ti.com> (raw)

Interrupts from i2c controller are enabled while i2c bus is in the
suspend mode (I2C_IE register doesn't equals to 0).

Starting from the OMAP chips with version2 registers scheme there
are 2 registers (I2C_IRQENABLE_SET and I2C_IRQENABLE_CLR) to manage
interrupts instead of the older OMAP chips old scheme which have
only one register (I2C_IE). Now for enabling interrupts we must
use I2C_IRQENABLE_SET register and for disabling interrupts we must
use I2C_IRQENABLE_CLR register.

Next patch fixes it.

Patch is based on:
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
tag: v3.10-rc2

Verified on OMAP4430.

Oleksandr Dmytryshyn (1):
  i2c: omap: correct usage of the interrupt enable register

 drivers/i2c/busses/i2c-omap.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

-- 
1.8.2.rc2


             reply	other threads:[~2013-05-29  7:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-29  7:35 Oleksandr Dmytryshyn [this message]
2013-05-29  7:35 ` [PATCH 1/1] " Oleksandr Dmytryshyn
2013-05-29 17:22   ` Kevin Hilman
2013-05-30  8:53     ` Oleksandr Dmytryshyn
2013-05-30 14:18       ` Kevin Hilman
2013-05-30 15:42         ` Oleksandr Dmytryshyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369812944-685-1-git-send-email-oleksandr.dmytryshyn@ti.com \
    --to=oleksandr.dmytryshyn@ti.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®